Useful Functions

[The King's Bastard]

Originally Posted by FireCat

OnPlayerMoneyChange v2

Faster, and better scripted.

new gOldMoney[MAX_PLAYERS];
public OnPlayerUpdate(playerid)
{
    static iM;
    iM = GetPlayerMoney(playerid);
    if(iM != gOldMoney[playerid])
    {
        CallLocalFunction("OnPlayerMoneyChange","ii",playerid,(iM-gOldMoney[playerid]));
        gOldMoney[playerid] = iM;
    }
    return 1;
}

public OnPlayerMoneyChange(playerid, iAmount)
{
    printf("Someone's money changed by $%i",iAmount);
    return 1;
}

Why would that be faster?
You just changed the local money variable to a static local variable.
Do you think it might be faster because memory doesn't have to be allocated every function call?

---

Why not just write global variables in camel case (GlobalVariable) and local variables in lower case (local_variable or localvariable)?

[FireCat]

Originally Posted by The King's Bastard

Why would that be faster?
You just changed the local money variable to a static local variable.
Do you think it might be faster because memory doesn't have to be allocated every function call?

---

Why not just write global variables in camel case (GlobalVariable) and local variables in lower case (local_variable or localvariable)?

First of all, gOldMoney is a global variable, so we put a g.
Second of all, I didn't just "change" to static, I allocated the variable iM, to GetPlayerMoney() so we don't have to call that function every time, its not like LOTS faster...
But if you use it for big codes, it can affect the performance of the server

Edit:
Testing Code

[15:04:31] Static and allocating the iM variable took 288 ms
[15:04:32] Static and not allocating the iM variable took 377 ms

[Slice]

You forgot to test just using "new". Or maybe you did, and realized there's hardly any difference.

[FireCat]

Originally Posted by Slice

You forgot to test just using "new". Or maybe you did, and realized there's hardly any difference.

Not even worth it

[Vince]

So, what's the point of calling OnPlayerMoneyChange through CallLocalFunction? Naturally, it'd be faster if it was called directly.

[Y_Less]

Yes, but if the user doesn't have that callback the code won't even compile. By not using CallLocalFunction you FORCE the user to include that callback even if they don't want it.

[Slice]

Non-recursive quicksort - sorts an array of plain integers.

stock QuickSort(numbers[], size = sizeof(numbers)) {
    #define PUSH(%1,%2)      (stack[top][0] = (%1), stack[top][1] = (%2), top++)
    #define POP(%1,%2)       (--top, (%1 = stack[top][0]), (%2 = stack[top][1]))
    
    static stack[256][2];
    new top = 0;
    
    if (size <= 1)
        return;
    
    new left, right, pivot, l_hold, r_hold;
    
    PUSH(0, size - 1);
    
    while (0 < top) {
        POP(left, right);
        
        pivot = numbers[left];
        l_hold = left;
        r_hold = right;

        // insertion sort for small fragments
        if (right - left <= 6) {
            insertion_sort(numbers, left, right);

            continue;
        }

        while (left < right) {
            while (numbers[right] >= pivot && left < right)
                right--;

            if (left != right) {
                numbers[left] = numbers[right];
                left++;
            }

            while (numbers[left] <= pivot && left < right)
                left++;

            if (left != right) {
                numbers[right] = numbers[left];
                right--;
            }
        }

        numbers[left] = pivot;
        pivot = left;
        left = l_hold;
        right = r_hold;
        
        if (left < pivot)  PUSH(left, pivot - 1);
        if (right > pivot) PUSH(pivot + 1, right);
    }
    
    #undef PUSH
    #undef POP
}

stock insertion_sort(array[], left, right) {
    for (new j = left + 1; j <= right; j++) {
        new key = array[j], i = j - 1;
        
        while (i >= left && array[i] > key) {
            array[i + 1] = array[i];
            
            i--;
        }
        
        array[i + 1] = key;
    }
}

[Y_Less]

Now where have I seen that code before...

I'm slightly surprised you didn't keep the GPL notice from the GNU original. I've debated porting that function before but can't stand GPL!

[FireCat]

IsPlayerInArea and IsPlayerInArea3D

public IsPlayerInArea(playerid,Float:fXMax,Float:fYMax,Float:fXMin,Float:fYMin) //By: Firecat
{
    new
        Float:fX,Float:fY,Float:fZ;
        
    GetPlayerPos(playerid,fX,fY,fZ);
    if(((fX >= fXMin) && (fX <= fXMax)) && ((fY >= fYMin) &&(fY <= fYMax)))
        return 1;
    return 0;
}


public IsPlayerInArea3D(playerid,Float:fXMax,Float:fYMax,Float:fZMax,Float:fXMin,Float:fYMin,Float:fZMin) //By: Firecat
{
    static
        Float:fX,Float:fY,Float:fZ;

    GetPlayerPos(playerid,fX,fY,fZ);
    if(((fX >= fXMin) && (fX <= fXMax)) && ((fY >= fYMin) && (fY <= fYMax)) && ((fZ >= fZMin) && (fZ <= fZMax)))
        return 1;
    return 0;
}

[Slice]

Originally Posted by Y_Less

Now where have I seen that code before...

I'm slightly surprised you didn't keep the GPL notice from the GNU original. I've debated porting that function before but can't stand GPL!

Sorry, I was unsure exactly where it originally came from as it was inside an old scribble file.
The original one is actually made by you (from YSI_Misc.own), which is adapted from some WKU page (dead link).
After that I looked through a number of different implementations.