SA-MP Forums

Go Back   SA-MP Forums > SA-MP Scripting and Plugins > Filterscripts

Reply
 
Thread Tools Display Modes
Old 20/03/2017, 12:14 AM   #21
AndySedeyn
High-roller
 
AndySedeyn's Avatar
 
Join Date: Feb 2014
Location: Belgium
Posts: 1,350
Reputation: 676
Default Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

I like how you put excessive whitespaces everywhere and then cram everything together elsewhere:
PHP Code:
for( new j=0;j<6;j++ ) 
xd
AndySedeyn is offline   Reply With Quote
Old 20/03/2017, 09:33 AM   #22
Logic_
High-roller
 
Logic_'s Avatar
 
Join Date: Jun 2015
Location: Eating peanut butter and jelly fishes on toast
Posts: 1,059
Reputation: 97
Default Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

Some errors:
1. You're mixing indentation styles.

2. This can be shortened:
PHP Code:
JOB_DELIVERER_VEHICLESDELIVERER_VEHICLES] ] = 0JOB_DELIVERER_VEHICLESDELIVERER_VEHICLES] ]= 0;
    
JOB_DELIVERER_VEHICLESDELIVERER_VEHICLES] ] = 0JOB_DELIVERER_VEHICLESDELIVERER_VEHICLES] ]= 0;
    
JOB_DELIVERER_VEHICLESDELIVERER_VEHICLES] ] = 0JOB_DELIVERER_VEHICLESDELIVERER_VEHICLES] ]= 0
3. Your commands has a very different style, which can be shortened.

4. Remove , params[]) if params aren't used in the commands.

5. Why you're using public keyword and forwarding them if they are used like ordinary functions?

6. Optimize this
PHP Code:
if(VID == DELIVERER_VEHICLES] || VID == DELIVERER_VEHICLES] || VID == DELIVERER_VEHICLES] || VID == DELIVERER_VEHICLES] || VID == DELIVERER_VEHICLES] || VID == DELIVERER_VEHICLES]) 
7. Shorten if statements by combining them into one or so.

8. Use Streamer functions instead of using ordinary checkpoints or pick-ups, use dynamic areas and stuff.
__________________
Working on...
| Prison RP (35%) |


Link to my works
Logic_ is offline   Reply With Quote
Old 20/03/2017, 03:12 PM   #23
Scripter18
Gangsta
 
Scripter18's Avatar
 
Join Date: Aug 2015
Location: Croatia
Posts: 563
Reputation: 62
Default Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

Quote:
Originally Posted by AndySedeyn View Post
I like how you put excessive whitespaces everywhere and then cram everything together elsewhere:
PHP Code:
for( new j=0;j<6;j++ ) 
xd
Going to solve this all soon as i re-install my windows
Scripter18 is offline   Reply With Quote
Old 20/03/2017, 04:51 PM   #24
Hunud
Huge Clucker
 
Join Date: Jun 2016
Posts: 305
Reputation: 2
Default Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

Will wait for fix. Keep good work
Hunud is offline   Reply With Quote
Old 20/03/2017, 06:32 PM   #25
Scripter18
Gangsta
 
Scripter18's Avatar
 
Join Date: Aug 2015
Location: Croatia
Posts: 563
Reputation: 62
Default Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

Tnx
Scripter18 is offline   Reply With Quote
Old 21/03/2017, 11:18 AM   #26
Hunud
Huge Clucker
 
Join Date: Jun 2016
Posts: 305
Reputation: 2
Default Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

I make new map and there is remove object but where i put it?
Hunud is offline   Reply With Quote
Old 21/03/2017, 06:23 PM   #27
Scripter18
Gangsta
 
Scripter18's Avatar
 
Join Date: Aug 2015
Location: Croatia
Posts: 563
Reputation: 62
Default Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

Quote:
Originally Posted by Hunud View Post
I make new map and there is remove object but where i put it?
New objects replace inside OnFilterScriptInit() and RemoveBuildingForPlayer inside OnPlayerConnect()

OT: *Some changes are made in script!*
Scripter18 is offline   Reply With Quote
Old 23/03/2017, 06:31 PM   #28
IcePop
Little Clucker
 
IcePop's Avatar
 
Join Date: Mar 2017
Location: Tandag, Surigao del Sur (Philippines)
Posts: 12
Reputation: 1
Default Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

Nice released bro!
__________________

Dynamic Land System | Dynamic Furniture System | Dynamic Robbery System | Dynamic Neon System
And Much More, Join Us Now!

samp.empiralgaming.com:7777
ts.empiralgaming.com
empiralgaming.com
IcePop is offline   Reply With Quote
Old 23/03/2017, 08:02 PM   #29
Scripter18
Gangsta
 
Scripter18's Avatar
 
Join Date: Aug 2015
Location: Croatia
Posts: 563
Reputation: 62
Default Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

Thanks
Scripter18 is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Fuel Deliverer Job v1.5 | Presentation (Croatian Language) Scripter18 Screenshots and Videos 29 20/03/2017 04:55 PM
iZCMD Josh_Main Scripting Help 5 08/09/2016 05:23 PM
IZCMD WhiteGhost Scripting Help 5 30/05/2016 04:57 AM
[GameMode] Death Match ( Zcmd - Sscanf2 - Foreach - Streamer ) Diogo123 Lanšamentos/Releases 14 15/03/2013 09:33 PM


All times are GMT. The time now is 08:10 PM.


Powered by vBulletin® Version 3.8.6
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.