SA-MP Forums

Go Back   SA-MP Forums > SA-MP Scripting and Plugins > Filterscripts

Reply
 
Thread Tools Display Modes
Old 29/08/2017, 05:32 PM   #1
OfekEfron
Little Clucker
 
Join Date: Aug 2017
Posts: 5
Reputation: 0
Default Simple VIP System

Simple VIP System
by: James_Barnes(OfekEfron).


Lines: 137
Bugs: 0 (replay me if you find something i will fix it)
Pastebin: Here

Commands:
HTML Code:
/SetVIPManager - Give someone VIP Manager (Rcon / VIP Manager)
/DelVIPManager - Remove someone from VIP Manager (Rcon / VIP Manager)
/SetVIP - Set someone VIP
/DelVIP - Remove someone from VIP
/VSay - Say in global chat lime VIP
/VGoto - Teleport to someone from VIP
/VipColor - Change your color to VIP Color
/VIPHelp - Menu help to VIP
__________________
My Roleplay Server:

IP Address: server.legacy-rp.com:9999
Forum: Legay-RP.com
TS3 IP Address: ts.legacy-rp.com:9559

James_Barnes.

Last edited by OfekEfron; 30/08/2017 at 10:21 AM.
OfekEfron is offline   Reply With Quote
Old 29/08/2017, 06:30 PM   #2
Eoussama
High-roller
 
Eoussama's Avatar
 
Join Date: Jul 2016
Location: Kingdom of Morocco // Tangier
Posts: 1,126
Reputation: 153
Default Re: Simple VIP System

Why did you define these colors if you are not going to use them in the first place?
PHP Code:
#define COLOR_GREEN 0x1AFF00AA
#define COLOR_YELLOW 0xF6FF00AA
#define COLOR_BLUE 0x0055ffAA
#define COLOR_WHITE 0xFFFFFFAA
#define COLOR_LBLUE 0x00aaffAA
#define COLOR_ORANGE 0xFFA600AA 
global variable to work with strings (new str[500];)? Terrible.

You do not need parameters in this command (CMD:viphelp(playerid,params[])) So drop the (params[])

Why did you stick stock mindlessly to all of your functions? Have a look at this http://forum.sa-mp.com/showthread.php?t=570635

The list goes long, I'm just going to stop here, and also, please take time to least organize your thread. Add colors, decorate your paragraphs, upload images...
__________________
Eoussama is offline   Reply With Quote
Old 30/08/2017, 09:53 AM   #3
SonnyGamer
Big Clucker
 
SonnyGamer's Avatar
 
Join Date: Jun 2017
Location: Russia
Posts: 79
Reputation: 25
Default Re: Simple VIP System

You did not work hard for making good VIP system, instead of that you made it simple.
1/10
SonnyGamer is offline   Reply With Quote
Old 30/08/2017, 09:56 AM   #4
Ultraz
Banned
 
Join Date: Aug 2016
Location: Egypt
Posts: 213
Reputation: 19
Default Re: Simple VIP System

Quote:
Originally Posted by OfekEfron View Post
Bugs: 0 (replay me if you find something i will fix it)
Pastebin: Here[/CENTER]
so can you make some efforts and add pictures,the commands list,anything so we can be intersted to use this VIP System?
Ultraz is offline   Reply With Quote
Old 30/08/2017, 10:22 AM   #5
OfekEfron
Little Clucker
 
Join Date: Aug 2017
Posts: 5
Reputation: 0
Default Re: Simple VIP System

Quote:
Originally Posted by Ultraz View Post
so can you make some efforts and add pictures,the commands list,anything so we can be intersted to use this VIP System?
Added list of command you can check this out.
__________________
My Roleplay Server:

IP Address: server.legacy-rp.com:9999
Forum: Legay-RP.com
TS3 IP Address: ts.legacy-rp.com:9559

James_Barnes.
OfekEfron is offline   Reply With Quote
Old 09/09/2017, 01:40 PM   #6
HoNEYKISS
Little Clucker
 
Join Date: Aug 2017
Location: Greece
Posts: 19
Reputation: 0
Default Re: Simple VIP System

too simple
HoNEYKISS is offline   Reply With Quote
Old 09/09/2017, 03:34 PM   #7
BiosMarcel
High-roller
 
BiosMarcel's Avatar
 
Join Date: Jul 2012
Location: Germany
Posts: 1,231
Reputation: 201
Default Re: Simple VIP System

@OfekEfron

Would you be kind enough to explain the following keyword for me

PHP Code:
stock 
BiosMarcel is offline   Reply With Quote
Old 09/09/2017, 03:48 PM   #8
Meller
Gangsta
 
Meller's Avatar
 
Join Date: Dec 2016
Posts: 607
Reputation: 108
Default Re: Simple VIP System

Quote:
Originally Posted by [Bios]Marcel View Post
@OfekEfron

Would you be kind enough to explain the following keyword for me

PHP Code:
stock 
http://wiki.sa-mp.com/wiki/Stock#stock


Everything you need to know about PAWN in general is actually available at SAMP's wiki.
__________________
#me too
Meller is online now   Reply With Quote
Old 09/09/2017, 03:57 PM   #9
Xeon™
Gangsta
 
Xeon™'s Avatar
 
Join Date: Jul 2017
Location: Earth
Posts: 517
Reputation: 73
Default Re: Simple VIP System

0 Bugs?

First bug: you are using an full outdated saving system (DOF2)

Second bug: you are using "str" a global variable while you are using it locally so this will create so many wrrong formating for strings and so many mistakes/bugs. also with "500 cells"? that wast of shit.

Third bug: you are using "stock" in a local script, that's not an include nor module system (even modules doesn't use "stock")

Bug #4: Last function in script not needed, this can be done simpley by using #define

Bug #5: in all administrative commands you are using "SVIP(playerid)" so you are checking if player is vip, then the player will be able to use the /setvip.... to set another player vip which is terrible...

Bug #6: in /viplist you are formatting lines to be used on a dialog, note that won't return more than 1 long line because you didn't use "\n" to return to the line

Bug #7: in another command you are using " if(sscanf(params,"u",params[0])) " we'all know this won't work correctly, you are using cells to store an integer, note that params[0] is already this integer, so you should declare a new variable instand of using the native string.

Bug #8 (7.2): in /vsay you are using the samething, but you are returning only the first char of the whole text, because of using params[0] (i bet that you don't know how cells works)

Fatal Bug #9:

PHP Code:
public OnFilterScriptInit()
{
    
DOF2_Exit();
    return 
1;

this won't let the DOF2 functions to work, because you already shutted it down

Conclusion: nothing will work in this script.

Now you have bugs to start fixing it ^^



Edit: @Meller http://forum.sa-mp.com/showthread.php?t=570635 ( ͡° ͜ʖ ͡°)
Xeon™ is offline   Reply With Quote
Old 09/09/2017, 04:30 PM   #10
BiosMarcel
High-roller
 
BiosMarcel's Avatar
 
Join Date: Jul 2012
Location: Germany
Posts: 1,231
Reputation: 201
Default Re: Simple VIP System

Quote:
Originally Posted by Meller View Post
http://wiki.sa-mp.com/wiki/Stock#stock


Everything you need to know about PAWN in general is actually available at SAMP's wiki.
For fucks sake, meller ... ofc i know what stock means, but he doesn't because he uses it because he didn't question if its necessary.
BiosMarcel is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
[FilterScript] Experience system + Simple Account System KingHual Filterscripts 72 27/06/2015 10:07 PM
[FilterScript] Simple Briefcase System + A Simple Whisper System by kosa451 kosa451 Filterscripts 4 16/09/2013 09:20 PM
[FilterScript] Simple AFK System misho1 Filterscripts 21 08/08/2012 06:25 PM


All times are GMT. The time now is 12:30 AM.


Powered by vBulletin® Version 3.8.6
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.