Have Problem please help

[rumen98]

Hey people tried to do a check command but it did nothing to try it on another player shows my stats I need for an RP I'm doing

PHP Code:

CMD:check(playerid, params[])
{
    new gamer;
    new atext[128];
    new atext2[128];
    new nivo = PlayerInfo[playerid][Hungry];
    new nivo2 = PlayerInfo[gamer][Hungry];

    if(!IsPlayerAdmin(playerid))
        return SendClientMessage(playerid, COLOR_RED, "Äîñòúï îòêàçàí.");
    if (sscanf(params, "u", gamer)) SendClientMessage(playerid, COLOR_RED, "Èçïîëçâàé: \"/check <Èãðà÷>");
    else if (gamer == INVALID_PLAYER_ID) SendClientMessage(playerid, COLOR_RED, "Èãðà÷à íà å íàìåðåí");
    else
    {
        format (atext, sizeof(atext), "Hungry on player:%d",nivo);
        format (atext2, sizeof(atext2), "Hungry on player:%d",nivo2);
        SendClientMessage(playerid, COLOR_PURPLE, atext2);
        SendClientMessage(playerid, COLOR_PURPLE, atext);

    }
    return 1;
} 


[AndreT]

Let me show you what you do here:

new gamer;
new nivo2 = PlayerInfo[gamer][Hungry];

if(sscanf(params, "u", gamer)) // ...

The problem here is that you get the value of PlayerInfo[gamer][Hungry] before you even know what the gamer is supposed to be. So it always takes the Hungry value of player 0 (new variables are initialized with a 0 value).

What you need to do instead is:

new gamer;
if(sscanf(params, "u", gamer))
{
    // ...
}
new nivo2 = PlayerInfo[gamer][Hungry];

This way, nivo2 will have a proper value.

Also what you do here:

format (atext, sizeof(atext), "Hungry on player:%d",nivo);
format (atext2, sizeof(atext2), "Hungry on player:%d",nivo2);
SendClientMessage(playerid, COLOR_PURPLE, atext2);
SendClientMessage(playerid, COLOR_PURPLE, atext);

This uses 2 arrays to send these text lines, you could instead use only one:

format(atext, sizeof(atext), "Hungry on player: %d", nivo);
SendClientMessage(playerid, COLOR_PURPLE, atext);
format(atext, sizeof(atext), "Hungry on player: %d", nivo2);
SendClientMessage(playerid, COLOR_PURPLE, atext);

[rumen98]

Originally Posted by AndreT

Let me show you what you do here:

new gamer;
new nivo2 = PlayerInfo[gamer][Hungry];

if(sscanf(params, "u", gamer)) // ...

The problem here is that you get the value of PlayerInfo[gamer][Hungry] before you even know what the gamer is supposed to be. So it always takes the Hungry value of player 0 (new variables are initialized with a 0 value).

What you need to do instead is:

new gamer;
if(sscanf(params, "u", gamer))
{
    // ...
}
new nivo2 = PlayerInfo[gamer][Hungry];

This way, nivo2 will have a proper value.

Also what you do here:

format (atext, sizeof(atext), "Hungry on player:%d",nivo);
format (atext2, sizeof(atext2), "Hungry on player:%d",nivo2);
SendClientMessage(playerid, COLOR_PURPLE, atext2);
SendClientMessage(playerid, COLOR_PURPLE, atext);

This uses 2 arrays to send these text lines, you could instead use only one:

format(atext, sizeof(atext), "Hungry on player: %d", nivo);
SendClientMessage(playerid, COLOR_PURPLE, atext);
format(atext, sizeof(atext), "Hungry on player: %d", nivo2);
SendClientMessage(playerid, COLOR_PURPLE, atext);

thanks i will try it