SA-MP Forums

Go Back   SA-MP Forums > SA-MP Scripting and Plugins > Filterscripts > Includes

Reply
 
Thread Tools Display Modes
Old 01/07/2015, 04:31 PM   #21
Yashas
Gangsta
 
Join Date: Jun 2012
Location: India
Posts: 882
Reputation: 266
Default Re: Nex-AC - Anticheat system

The pro-aim detection will fail.

Code:
IsPlayerInRangeOfPoint(hitid, 3.0, fPos[0], fPos[1], fPos[2])
I have done some research and figured out that at least 10 units should be allowed for variation. Sometimes player who are not using proaim can also shoot with deviation of 3 units due to lag. (3 units variation can be caused even with pings near 200)

Anti-Aimbot Include
I had made an anti-aimbot (proaim) which does many checks. The include has been revised many times and now it is quite stable.

You need to optimize your script:
Since you have lot of Anti-Hacks in your include and with the amount of code, you should consider optimizing the include.

There are lot of bad code in the include.

Refer these links to learn more:
Yashas is offline   Reply With Quote
Old 01/07/2015, 05:01 PM   #22
Carper
Little Clucker
 
Carper's Avatar
 
Join Date: Oct 2013
Posts: 39
Reputation: 5
Default AW: Nex-AC - Anticheat system

German Translation: http://www.solidfiles.com/d/65bd6fd22e/
Carper is offline   Reply With Quote
Old 01/07/2015, 05:07 PM   #23
Pottus
Godfather
 
Pottus's Avatar
 
Join Date: Jun 2012
Posts: 5,314
Reputation: 1171
Default Re: Nex-AC - Anticheat system

I have to agree with Yashas what here and would like to add some more input to the overall design of this system which definitely needs a lot of work but don't get me wrong there is a lot of potential here.

My main gripe with this is that all the code is in one include which looks really messy to me when this kind of system needs to be modular an include for each type of cheat. Currently trying to work with anything in this you don't have any checks isolated from others so debugging is easier. Now I know you could could still debug and change it not hard but you got to think what about everyone else? It doesn't matter if you can work on your own system but a good design choice is making sure anyone else can easily edit the script themselves if need be which allows for interchangeable includes to be developed.

Another thing is it looks really bad practice to index your variables the way you have for instance.
Code:
 else AntiCheatInfo[playerid][pFloodCount][13] = AntiCheatInfo[playerid][pFloodCount][27] = 0;
This is absolutely terrible and completely avoidable how is anyone to actually understand what that means remotely at first glance?
Pottus is offline   Reply With Quote
Old 01/07/2015, 05:09 PM   #24
Maximun
Gangsta
 
Join Date: Jan 2014
Location: Localhost
Posts: 667
Reputation: 32
Default Re: Nex-AC - Anticheat system

Excellent work! +REP
Maximun is offline   Reply With Quote
Old 01/07/2015, 05:09 PM   #25
SecretBoss
Gangsta
 
SecretBoss's Avatar
 
Join Date: Dec 2014
Location: Greece
Posts: 831
Reputation: 102
Default Re: Nex-AC - Anticheat system

Code:
nex-ac.inc(741) : warning 202: number of arguments does not match definition
nex-ac.inc(758) : warning 202: number of arguments does not match definition
nex-ac.inc(923) : error 017: undefined symbol "GetPlayerPoolSize"
nex-ac.inc(1648) : warning 201: redefinition of constant/macro (symbol "RepairVehicle")
nex-ac.inc(1742) : error 017: undefined symbol "GetPlayerPoolSize"
nex-ac.inc(1808) : error 017: undefined symbol "BlockIpAddress"
nex-ac.inc(1935) : error 025: function heading differs from prototype
nex-ac.inc(1939) : warning 202: number of arguments does not match definition
nex-ac.inc(1952) : error 025: function heading differs from prototype
nex-ac.inc(2831) : error 017: undefined symbol "VectorSize"
nex-ac.inc(3157) : error 017: undefined symbol "GetPlayerLastShotVectors"
nex-ac.inc(3709) : warning 201: redefinition of constant/macro (symbol "OnVehicleDamageStatusUpdate")
nex-ac.inc(3714) : warning 235: public function lacks forward declaration (symbol "OnVehicleSirenStateChange")
nex-ac.inc(3770) : error 025: function heading differs from prototype
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3832) : error 025: function heading differs from prototype
nex-ac.inc(3859) : error 017: undefined symbol "NetStats_MessagesRecvPerSecond"
nex-ac.inc(3971) : error 017: undefined symbol "BlockIpAddress"
nex-ac.inc(4056) : error 017: undefined symbol "VectorSize"
nex-ac.inc(4056) : warning 203: symbol is never used: "vZ"
nex-ac.inc(4056) : warning 203: symbol is never used: "vY"
nex-ac.inc(4056) : warning 203: symbol is never used: "vX"
dealer.inc(191) : warning 209: function "ac_OnVehiclePaintjob" should return a value
dealer.inc(213) : warning 209: function "ac_OnVehicleRespray" should return a value
dealer.inc(416) : warning 209: function "ac_OnVehicleDeath" should return a value
Any idea on this?
__________________
SecretBoss is offline   Reply With Quote
Old 01/07/2015, 05:19 PM   #26
Pottus
Godfather
 
Pottus's Avatar
 
Join Date: Jun 2012
Posts: 5,314
Reputation: 1171
Default Re: Nex-AC - Anticheat system

Quote:
Originally Posted by SecretBoss View Post
Code:
nex-ac.inc(741) : warning 202: number of arguments does not match definition
nex-ac.inc(758) : warning 202: number of arguments does not match definition
nex-ac.inc(923) : error 017: undefined symbol "GetPlayerPoolSize"
nex-ac.inc(1648) : warning 201: redefinition of constant/macro (symbol "RepairVehicle")
nex-ac.inc(1742) : error 017: undefined symbol "GetPlayerPoolSize"
nex-ac.inc(1808) : error 017: undefined symbol "BlockIpAddress"
nex-ac.inc(1935) : error 025: function heading differs from prototype
nex-ac.inc(1939) : warning 202: number of arguments does not match definition
nex-ac.inc(1952) : error 025: function heading differs from prototype
nex-ac.inc(2831) : error 017: undefined symbol "VectorSize"
nex-ac.inc(3157) : error 017: undefined symbol "GetPlayerLastShotVectors"
nex-ac.inc(3709) : warning 201: redefinition of constant/macro (symbol "OnVehicleDamageStatusUpdate")
nex-ac.inc(3714) : warning 235: public function lacks forward declaration (symbol "OnVehicleSirenStateChange")
nex-ac.inc(3770) : error 025: function heading differs from prototype
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3810) : warning 202: number of arguments does not match definition
nex-ac.inc(3832) : error 025: function heading differs from prototype
nex-ac.inc(3859) : error 017: undefined symbol "NetStats_MessagesRecvPerSecond"
nex-ac.inc(3971) : error 017: undefined symbol "BlockIpAddress"
nex-ac.inc(4056) : error 017: undefined symbol "VectorSize"
nex-ac.inc(4056) : warning 203: symbol is never used: "vZ"
nex-ac.inc(4056) : warning 203: symbol is never used: "vY"
nex-ac.inc(4056) : warning 203: symbol is never used: "vX"
dealer.inc(191) : warning 209: function "ac_OnVehiclePaintjob" should return a value
dealer.inc(213) : warning 209: function "ac_OnVehicleRespray" should return a value
dealer.inc(416) : warning 209: function "ac_OnVehicleDeath" should return a value
Any idea on this?
Problem with this system is it's not released/designed very well a lot of work needs to be done before this can be used I would think.
Pottus is offline   Reply With Quote
Old 01/07/2015, 05:21 PM   #27
Virtual1ty
Gangsta
 
Virtual1ty's Avatar
 
Join Date: Jun 2009
Location: Croatia (Hrvatska)
Posts: 750
Reputation: 97
Default Re: Nex-AC - Anticheat system

Adding on to Slice's post, why doesn't anyone take the abandoned Anticheat include by Dan... and just updates it? I believe it would be the best if someone would do that for the community, everyone could contribute to make the best server-side protection we could get.

Don't get me wrong, I (as Slice) agree that this has potential, but it could've been made better, as pointed out.
Nevertheless, great job considering the amount of time you probably put into it!
Virtual1ty is offline   Reply With Quote
Old 01/07/2015, 05:24 PM   #28
OstGot
Gangsta
 
OstGot's Avatar
 
Join Date: Mar 2013
Location: Gomel, Belarus
Posts: 599
Reputation: 247
Default Re: Nex-AC - Anticheat system

Quote:
Originally Posted by SecretBoss View Post
All of the above errors/warnings appeared when I included the nex-ac.inc, I checked it before including it
Which version of the samp are you using?
According to the log file, there is not even defined VectorSize, it leads me to such thoughts

Quote:
Originally Posted by Yashas View Post
The pro-aim detection will fail.
Quote:
Originally Posted by Pottus View Post
I have to agree with Yashas what here and would like to add some more input to the overall design of this system which definitely needs a lot of work but don't get me wrong there is a lot of potential here
Thank you for your research
Such posts are motivated for further development of the project.
And of course I'll work on it

Quote:
Originally Posted by Pottus View Post
Another thing is it looks really bad practice to index your variables the way you have for instance.
Code:
 else AntiCheatInfo[playerid][pFloodCount][13] = AntiCheatInfo[playerid][pFloodCount][27] = 0;
Honestly, I know this before, but as can be seen in practice, it works ..: D
Maybe that's why I chose this style of code writing

Quote:
Originally Posted by Carper View Post
Thank you very much!
__________________
aka Nexius
Don't want to always check for updates of my scripts?
Include it the last, after all others
Nexius's Update Checker
OstGot is offline   Reply With Quote
Old 01/07/2015, 05:27 PM   #29
Pottus
Godfather
 
Pottus's Avatar
 
Join Date: Jun 2012
Posts: 5,314
Reputation: 1171
Default Re: Nex-AC - Anticheat system

Yeah I would really start separating all my systems into their own includes once you do that then it will be really easy to optimize this script.

But it does compile I did it without problems but I am going to suggest that you put this project on github it will make releasing it easier and updating it easier.
Pottus is offline   Reply With Quote
Old 01/07/2015, 05:40 PM   #30
Jstylezzz
High-roller
 
Jstylezzz's Avatar
 
Join Date: Sep 2011
Location: the Netherlands
Posts: 2,957
Reputation: 1514
Default Re: Nex-AC - Anticheat system

I have a Dutch translation here. I also sent it through PM, but I read that posting it here directly will suffice ;P Hope this will be of use for anyone

Very nice work, great it has so much features
Jstylezzz is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Working AntiCheat system mrxqware Scripting Help 4 02/05/2014 12:04 PM
[Include] System AntiCheat V1.1 Glad2BeHere Includes 13 04/03/2013 08:33 PM
-AntiCheat System geohareas Scripting Help 5 08/01/2013 07:38 PM
[FilterScript] [FS] ZAdmin v1.0 | ADMIN SYSTEM + REGISTER + ANTICHEAT + ANTIFLOOD + ANTISWEAR. [ZFM]Zuc Filterscripts 24 25/05/2011 10:19 AM


All times are GMT. The time now is 07:23 AM.


Powered by vBulletin® Version 3.8.6
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.