[Include] foreach - 0.3 compatible - updated 19/12/12

[Gigi-The-Beast]

edit: found the problem, please delete the post

[Kar]

Originally Posted by Y_Less

This is officially the most useful bug report I've had on this! A few people have mentioned crashes before, but none have bothered to mention that they were using multi-dimensional arrays declared with the new unified syntax instead of the old "IteratorArray:" tag! As a result, I have found and fixed at least one bug that may solve your problem.

I was confused before, because they were always complaining that it crashed at "id = size", which actually isn't invaliad in foreach because some parts of the array are declared to be 1 cell bigger than you think they are for technical reasons.

I updated foreach and it's fixed now, thanks! Multi-Dimensional Arrays really helped the stability of my new server

I got another bug for you, the reason why I'm clearing the iterator is because Iter_Init isn't doing it.

Use this code

#define MAX_PLAYERS 64
#define MAX_COMPLETE_SLOTS 26 //These are just my conditions, nothing specific.

new
    Iterator:pSlots_In_Use[MAX_PLAYERS]<MAX_COMPLETE_SLOTS>;

public OnGameModeInit()
{
    Iter_Init(pSlots_In_Use);
    return 1;
}

public OnPlayerConnect(playerid) // I use it in a timer, but this should work.
{
    foreach(pSlots_In_Use[playerid], mu_slot)
    {
        printf("mu_slot: %d", mu_slot);
    }
    return 1;
}

Result:

[18:08:26] [debug] Run time error 4: "Array index out of bounds"
[18:08:26] [debug]   Accessing element at index 28 past array upper bound 25
[18:08:26] [debug] Backtrace:
[18:08:26] [debug] #0  00071edc in public MissileUpdate () at C:\DOCUME~1\MYDOCU~1\GRANDT~1\SA-MPS~2\GAMEMO~1\T_M.pwn:9209

This must be a bug, isn't Iter_Init surpose to clear the iterator?

[Y_Less]

There's no MissileUpdate there...

[Kar]

forward MissileUpdate();
SetTimer("MissileUpdate", 80, true);

new mu_id,
    mu_objectid,
    mu_vehicleid;
    //mu_slot;
    
public MissileUpdate()
{
    foreach(Player, i)
    {
        if(PlayerInfo[i][pSpawned] == 0) continue;
        mu_id = GetPlayerVehicleID(i);
        //for(mu_slot = 0; mu_slot < MAX_COMPLETE_SLOTS; mu_slot++)
        foreach(pSlots_In_Use[i], mu_slot)//crashes here.. same thing basically
        {
            //printf("%s mu_slot: %d", Playername(i), mu_slot);
            mu_objectid = Vehicle_Missile[mu_id][mu_slot];
            //rest code
        }
    }
}

Not much of a difference?

[Y_Less]

Just made an updated version, try that.

[cyber_punk]

Very nice the update fixed my issue. Thanks.

[Kar]

It's fixed now. Great job.

[SDraw]

I have a question:
Can I use iterator in enum like

PHP Code:

enum paramS { one,two,Iterator:This<128> };
new Info[128][paramS]; 


?

[wups]

Bug:

[14:56:58] [debug] Run time error 4: "Array index out of bounds"
[14:56:58] [debug] Accessing element at index 501 past array upper bound 499
[14:56:58] [debug] AMX backtrace:
[14:56:58] [debug] #0 00374168 in public Check () at GameMode.pwn:32865

Code:

new Busy[MAX_PLAYERS]; // max_players 500
    foreach (Player, playerid)
    {
        if(Busy[playerid]) // line 32865 
        {

The callback is called once every second, but this appears only sometimes.

[Y_Less]

I have never seen it hit something two above the max index (I fixed a one above bug). But without more information there's not much I can do.