Anti-Cheat Bug Help - SA-MP Forums

indy-greg · 06/09/2009, 04:13 PM

This anti cheat seems to have a bug that i need ironing out with the help from you guys/girls.

I dont get any errors and it does work when a player has any weapon they get banned.

BUT for some reason when a player joins when someone has cheated and got banned, they are banned. I'm still a beginner at scripting so im not sure whats wrong. Please help me out.

pawn Code:

forward timer();
public timer()
{
    for(new a=0; a<MAX_PLAYERS; a++)
    {
        if(IsPlayerConnected(a))
 {
    if(IsPlayerInAnyVehicle(a))
   {

            }
            else if(GetPlayerWeapon(a) >= 1)
            {
                GetPlayerName(a,pname,MAX_PLAYER_NAME);
                SendClientMessage(a,COLOR_RED,"You have been banned for weapon Cheats!");
                Ban(a);
                format(string,sizeof(string),"Player %s has been banned for using Cheats",pname);
                SendClientMessageToAll(COLOR_RED,string);
                return 1;
            }
            else
            {
                new Float:armour;
                GetPlayerArmour(a, armour);
                if(armour > 0.0)
                {
                  SendClientMessage(a, COLOR_RED, "Armour is not allowed on this server");
                    GetPlayerName(a, pname, MAX_PLAYER_NAME);
                    Ban(a);
                    format(string,sizeof(string),"Player %s has been banned for Armour Cheats",pname);
                    SendClientMessageToAll(COLOR_RED,string);
                }
            }
        }
    }
    return 1;
}

indy-greg · 06/09/2009, 04:16 PM

Sorry. forget this reply. Did it by accident. :@

Joe Staff · 06/09/2009, 04:19 PM

if(GetPlayerWeapon(a) >= 1)

If any player has a weapon that's on the WeaponID list higher than the brass knuckles (i.e. every weapon bust fists) the player gets banned?

indy-greg · 06/09/2009, 04:33 PM

No thats not the problem. Ive had it before without >= 1 and it still did the same thing.

Player Cheats = Gets Banned

Player joins after someone got banned = Gets Banned

yeswecanchange09 · 06/09/2009, 08:36 PM

pawn Code:

public timer()
{
    for(new a=0; a<MAX_PLAYERS; a++)
    {
        if(IsPlayerConnected(a))
        {
            new Float:armour;
            GetPlayerArmour(a, armour);
            
            if(IsPlayerInAnyVehicle(a))
            {

            }
            else if(GetPlayerWeapon(a) >= 1)
            {
                GetPlayerName(a,pname,MAX_PLAYER_NAME);
                SendClientMessage(a,COLOR_RED,"You have been banned for weapon Cheats!");
                Ban(a);

                format(string,sizeof(string),"Player %s has been banned for using Cheats",pname);
                SendClientMessageToAll(COLOR_RED,string);
                return 1;
            }
            else if(armour > 0.0)
            {
                SendClientMessage(a, COLOR_RED, "Armour is not allowed on this server");
                GetPlayerName(a, pname, MAX_PLAYER_NAME);
                Ban(a);
                    
                format(string,sizeof(string),"Player %s has been banned for Armour Cheats",pname);
                SendClientMessageToAll(COLOR_RED,string);
            }
        }
    }
    return 1;
}

dice7 · 06/09/2009, 08:44 PM

A little more optimized

pawn Code:

forward timer();
public timer()
{
    for(new a=0; a<MAX_PLAYERS; a++)
    {
        if(!IsPlayerConnected(a)) continue;
        if(!IsPlayerInAnyVehicle(a)) continue;

        if(GetPlayerWeapon(a) >= 1)
        {
            GetPlayerName(a,pname,MAX_PLAYER_NAME);
            SendClientMessage(a,COLOR_RED,"You have been banned for weapon Cheats!");
            Ban(a);

            format(string,sizeof(string),"Player %s has been banned for using Cheats",pname);
            SendClientMessageToAll(COLOR_RED,string);
            continue;
        }
        
        new Float:armour;
        GetPlayerArmour(a, armour);
        
        if(armour > 0.0)
        {
            SendClientMessage(a, COLOR_RED, "Armour is not allowed on this server");
            GetPlayerName(a, pname, MAX_PLAYER_NAME);
            Ban(a);

            format(string,sizeof(string),"Player %s has been banned for Armour Cheats",pname);
            SendClientMessageToAll(COLOR_RED,string);
        }
    }
    return 1;
}

Joe Staff · 07/09/2009, 03:25 AM

You guys don't seem to understand

pawn Code:

if(GetPlayerWeapon(a) >= 1)
{
  //ban code
}

GetPlayerWeapon gives you the weapon's ID, the only weapon that is weaponid '0' is the 'fists' weapon, or no weapon. So if you have ANY weapon, that above code will succeed and perform the ban code.

indy-greg · 07/09/2009, 05:11 PM

Quote:

Originally Posted by dice7

A little more optimized

pawn Code:

forward timer();
public timer()
{
    for(new a=0; a<MAX_PLAYERS; a++)
    {
        if(!IsPlayerConnected(a)) continue;
        if(!IsPlayerInAnyVehicle(a)) continue;

        if(GetPlayerWeapon(a) >= 1)
        {
            GetPlayerName(a,pname,MAX_PLAYER_NAME);
            SendClientMessage(a,COLOR_RED,"You have been banned for weapon Cheats!");
            Ban(a);

            format(string,sizeof(string),"Player %s has been banned for using Cheats",pname);
            SendClientMessageToAll(COLOR_RED,string);
            continue;
        }
        
        new Float:armour;
        GetPlayerArmour(a, armour);
        
        if(armour > 0.0)
        {
            SendClientMessage(a, COLOR_RED, "Armour is not allowed on this server");
            GetPlayerName(a, pname, MAX_PLAYER_NAME);
            Ban(a);

            format(string,sizeof(string),"Player %s has been banned for Armour Cheats",pname);
            SendClientMessageToAll(COLOR_RED,string);
        }
    }
    return 1;
}

That one doesnt seem to work at all now

indy-greg · 07/09/2009, 05:35 PM

Quote:

Originally Posted by Joe Staff

You guys don't seem to understand

pawn Code:

if(GetPlayerWeapon(a) >= 1)
{
  //ban code
}

GetPlayerWeapon gives you the weapon's ID, the only weapon that is weaponid '0' is the 'fists' weapon, or no weapon. So if you have ANY weapon, that above code will succeed and perform the ban code.

I dont get you. Are you saying thats a good thing or a bad thing?

Ironboy500 · 07/09/2009, 06:43 PM

Nice anti cheats, I will try to work on my server too.

06/09/2009, 04:16 PM	#2
indy-greg Little Clucker Join Date: Jan 2009 Posts: 22 Reputation: 0	Re: Anti-Cheat Bug Help Sorry. forget this reply. Did it by accident. :@

06/09/2009, 04:19 PM	#3
Joe Staff High-roller Join Date: Aug 2007 Posts: 2,740 Reputation: 327	Re: Anti-Cheat Bug Help if(GetPlayerWeapon(a) >= 1) If any player has a weapon that's on the WeaponID list higher than the brass knuckles (i.e. every weapon bust fists) the player gets banned? __________________ I've climbed castle Loch Ness in Scotland, surfed on Waikiki beach in Hawaii, got ripped off in the Bahamas, saw pirates fighting each other in Las Vegas, Nevada, hiked Mount St. Helens in Washington, drank from Crater Lake in Oregon, floated down rivers in Honduras, toured Hearst Castle in California, watched ice burgs break apart in Alaska, bought a stuft toy dog in a can in Canada, seen the 'Miraculous Stair' in Sante Fe, New Mexico, almost bought a rifle at the Alamo in Texas, and took a pee in an expensive restaurant in Paris, France. All before graduating. Travel when you're young, it tends to stick to you.

06/09/2009, 04:33 PM	#4
indy-greg Little Clucker Join Date: Jan 2009 Posts: 22 Reputation: 0	Re: Anti-Cheat Bug Help No thats not the problem. Ive had it before without >= 1 and it still did the same thing. Player Cheats = Gets Banned Player joins after someone got banned = Gets Banned

07/09/2009, 03:25 AM	#7
Joe Staff High-roller Join Date: Aug 2007 Posts: 2,740 Reputation: 327	Re: Anti-Cheat Bug Help You guys don't seem to understand pawn Code: if(GetPlayerWeapon(a) >= 1) { //ban code } GetPlayerWeapon gives you the weapon's ID, the only weapon that is weaponid '0' is the 'fists' weapon, or no weapon. So if you have ANY weapon, that above code will succeed and perform the ban code. __________________ I've climbed castle Loch Ness in Scotland, surfed on Waikiki beach in Hawaii, got ripped off in the Bahamas, saw pirates fighting each other in Las Vegas, Nevada, hiked Mount St. Helens in Washington, drank from Crater Lake in Oregon, floated down rivers in Honduras, toured Hearst Castle in California, watched ice burgs break apart in Alaska, bought a stuft toy dog in a can in Canada, seen the 'Miraculous Stair' in Sante Fe, New Mexico, almost bought a rifle at the Alamo in Texas, and took a pee in an expensive restaurant in Paris, France. All before graduating. Travel when you're young, it tends to stick to you.

07/09/2009, 06:43 PM	#10
Ironboy500 Huge Clucker Join Date: Jul 2009 Posts: 289 Reputation: 0	Re: Anti-Cheat Bug Help Nice anti cheats, I will try to work on my server too.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[Include] [INC] Anti Money Cheat, Anti Ban Weapon	FreshKilla	Includes	27	14/05/2011 10:31 AM
[FilterScript] [FS] Gun Anti-Cheat by me	DizeL-ZR-	Filterscripts	5	14/02/2010 09:07 AM
Anti Cheat	bluray	Help Archive	1	19/01/2010 10:38 AM
Help\|Anti Cheat	Fredy_Cole	Help Archive	2	27/09/2009 07:20 PM