PDA

View Full Version : Server Crashing


kbalor
15/09/2012, 07:00 PM
Everytime player pick this pickup, server always restarts and people always reconnecting. There is something wrong with the code below?

public OnPlayerPickUpPickup(playerid, pickupid)
{
for(new i = 0; i < MAX_PLAYERS; i++)
{
if(pickupid == tombstonePickups[i] && i != playerid)
{
new tombstring[128],tombname[MAX_PLAYER_NAME];
GetPlayerName(i,tombname,sizeof(tombname));
format(tombstring,sizeof(tombstring), "~g~+$400 ~n~~r~Coffin of:~n~~w~%s", tombname);
GameTextForPlayer(playerid,tombstring,3000,3);
DestroyPickup(tombstonePickups[i]); //Since you want to remove the coffin of the player that is dead, you'll have to place 'i' and not 'playerid'
tombstonePickups[i] = -1; // Same for here
GivePlayerMoney(playerid, 400);
break;
}
}
return 1;
}

KoczkaHUN
15/09/2012, 07:04 PM
Is tombstonePickups MAX_PLAYERS big? How do you create it?
new tombstonePickups[MAX_PLAYERS]; ?

scottyishere
15/09/2012, 07:07 PM
public OnPlayerPickUpPickup(playerid, pickupid)
{
for(new i = 0; i < MAX_PLAYERS; i++)
{
if(!IsPlayerConnected(i)) continue;
if(pickupid == tombstonePickups[i] && i != playerid)
{
new tombstring[128],tombname[MAX_PLAYER_NAME];
GetPlayerName(i,tombname,sizeof(tombname));
format(tombstring,sizeof(tombstring), "~g~+$400 ~n~~r~Coffin of:~n~~w~%s", tombname);
GameTextForPlayer(playerid,tombstring,3000,3);
DestroyPickup(tombstonePickups[i]); //Since you want to remove the coffin of the player that is dead, you'll have to place 'i' and not 'playerid'
tombstonePickups[i] = -1; // Same for here
GivePlayerMoney(playerid, 400);
break;
}
}
return 1;
}

Try this.

kbalor
15/09/2012, 07:10 PM
public OnPlayerPickUpPickup(playerid, pickupid)
{
for(new i = 0; i < MAX_PLAYERS; i++)
{
if(!IsPlayerConnected(i)) continue;
if(pickupid == tombstonePickups[i] && i != playerid)
{
new tombstring[128],tombname[MAX_PLAYER_NAME];
GetPlayerName(i,tombname,sizeof(tombname));
format(tombstring,sizeof(tombstring), "~g~+$400 ~n~~r~Coffin of:~n~~w~%s", tombname);
GameTextForPlayer(playerid,tombstring,3000,3);
DestroyPickup(tombstonePickups[i]); //Since you want to remove the coffin of the player that is dead, you'll have to place 'i' and not 'playerid'
tombstonePickups[i] = -1; // Same for here
GivePlayerMoney(playerid, 400);
break;
}
}
return 1;
}

Try this.


Okay, man I should try this!

@KoczkaHUN - I have already that on top of my script :) thanks!


+rep both