Thread: [Include] Nex-AC - Anticheat system
View Single Post
Old 01/07/2015, 04:07 PM   #23
Pottus's Avatar
Join Date: Jun 2012
Posts: 4,885
Reputation: 1351
Default Re: Nex-AC - Anticheat system

I have to agree with Yashas what here and would like to add some more input to the overall design of this system which definitely needs a lot of work but don't get me wrong there is a lot of potential here.

My main gripe with this is that all the code is in one include which looks really messy to me when this kind of system needs to be modular an include for each type of cheat. Currently trying to work with anything in this you don't have any checks isolated from others so debugging is easier. Now I know you could could still debug and change it not hard but you got to think what about everyone else? It doesn't matter if you can work on your own system but a good design choice is making sure anyone else can easily edit the script themselves if need be which allows for interchangeable includes to be developed.

Another thing is it looks really bad practice to index your variables the way you have for instance.
 else AntiCheatInfo[playerid][pFloodCount][13] = AntiCheatInfo[playerid][pFloodCount][27] = 0;
This is absolutely terrible and completely avoidable how is anyone to actually understand what that means remotely at first glance?
Pottus is offline   Reply With Quote