Thread: [FilterScript] Deer Hunter Job
View Single Post
Old 20/07/2018, 02:55 PM   #4
Kristall
Little Clucker
 
Kristall's Avatar
 
Join Date: Mar 2018
Location: Romania
Posts: 10
Reputation: 1
Default Re: Deer Hunter Job

Quote:
Originally Posted by CodeStyle175 View Post
again wtf is this shit?
why are you repeating useless code liks this?
PHP Code:
     if(PRESSED(KEY_WALK)) {
        if(
Deep_Deer[playerid] == 1) {
            if(
IsPlayerInRangeOfPoint(playerid3.52046.7698, -799.4532126.7188) && Deer[playerid] == 1) {
                
TogglePlayerControllable(playerid0);
                
ApplyAnimation(playerid"BOMBER""BOM_Plant"4.1111110);
                
Deep_Deer[playerid] = 0;
                
KillTimer(Meeters_BTWDeer[playerid]);
                
Shoot_Deer[playerid] = 0;
                
SetTimer("Done_Deer"3500false);
            }else if(
IsPlayerInRangeOfPoint(playerid3.52021.1818, -494.020776.1904) && Deer[playerid] == 2) {
                
TogglePlayerControllable(playerid0);
                
ApplyAnimation(playerid"BOMBER""BOM_Plant"4.1111110);
                
Deep_Deer[playerid] = 0;
                
KillTimer(Meeters_BTWDeer[playerid]);
                
Shoot_Deer[playerid] = 0;
                
SetTimer("Done_Deer"3500false);
            }else if(
IsPlayerInRangeOfPoint(playerid3.51632.5769, -599.744461.8233) && Deer[playerid] == 3) {
                
TogglePlayerControllable(playerid0);
                
ApplyAnimation(playerid"BOMBER""BOM_Plant"4.1111110);
                
Deep_Deer[playerid] = 0;
                
KillTimer(Meeters_BTWDeer[playerid]);
                
Shoot_Deer[playerid] = 0;
                
SetTimer("Done_Deer"3500false);
            }else if(
IsPlayerInRangeOfPoint(playerid3.51741.4386, -979.581736.6115) && Deer[playerid] == 4) {
                
TogglePlayerControllable(playerid0);
                
ApplyAnimation(playerid"BOMBER""BOM_Plant"4.1111110);
                
Deep_Deer[playerid] = 0;
                
KillTimer(Meeters_BTWDeer[playerid]);
                
Shoot_Deer[playerid] = 0;
                
SetTimer("Done_Deer"3500false);
            }else if(
IsPlayerInRangeOfPoint(playerid3.52553.6780, -963.433881.6685) && Deer[playerid] == 5) {
                
ApplyAnimation(playerid"BOMBER""BOM_Plant"4.1111110);
                
TogglePlayerControllable(playerid0);
                
Deep_Deer[playerid] = 0;
                
KillTimer(Meeters_BTWDeer[playerid]);
                
Shoot_Deer[playerid] = 0;
                
SetTimer("Done_Deer"3500false);
            }else if(
IsPlayerInRangeOfPoint(playerid3.52637.4963, -380.219557.9261) && Deer[playerid] == 6) {
                
ApplyAnimation(playerid"BOMBER""BOM_Plant"4.1111110);
                
TogglePlayerControllable(playerid0);
                
Deep_Deer[playerid] = 0;
                
KillTimer(Meeters_BTWDeer[playerid]);
                
Shoot_Deer[playerid] = 0;
                
SetTimer("Done_Deer"3500false);
            }else if(
IsPlayerInRangeOfPoint(playerid3.52406.9773, -403.468172.1762) && Deer[playerid] == 7) {
                
ApplyAnimation(playerid"BOMBER""BOM_Plant"4.1111110);
                
TogglePlayerControllable(playerid0);
                
Deep_Deer[playerid] = 0;
                
KillTimer(Meeters_BTWDeer[playerid]);
                
Shoot_Deer[playerid] = 0;
                
SetTimer("Done_Deer"3500false);
            }
         }
     } 
can be done this
PHP Code:
if(Deep_Deer[playerid] == 1) {
        if(
IsPlayerInRangeOfPoint(playerid3.52046.7698, -799.4532126.7188) && Deer[playerid] == || 
        
IsPlayerInRangeOfPoint(playerid3.52021.1818, -494.020776.1904) && Deer[playerid] == ||
        
IsPlayerInRangeOfPoint(playerid3.51632.5769, -599.744461.8233) && Deer[playerid] == ||
        
IsPlayerInRangeOfPoint(playerid3.51741.4386, -979.581736.6115) && Deer[playerid] == ||
        
IsPlayerInRangeOfPoint(playerid3.52553.6780, -963.433881.6685) && Deer[playerid] == ||
        
IsPlayerInRangeOfPoint(playerid3.52637.4963, -380.219557.9261) && Deer[playerid] == ||
        
IsPlayerInRangeOfPoint(playerid3.52406.9773, -403.468172.1762) && Deer[playerid] == 7){
            
TogglePlayerControllable(playerid0);
            
ApplyAnimation(playerid"BOMBER""BOM_Plant"4.1111110);
            
Deep_Deer[playerid] = 0;
            
KillTimer(Meeters_BTWDeer[playerid]);
            
Shoot_Deer[playerid] = 0;
            
SetTimer("Done_Deer"3500false);
        }
    } 
Every time I finish doing an FS, I look around the code and realize that I could very easily reduce the number of lines exactly as you did. Thank you for your referral, and next time I'm going to try not to throw any unnecessary code lines. See' ya!
Kristall is offline   Reply With Quote