SA-MP Forums

Go Back   SA-MP Forums > SA-MP Scripting and Plugins > Filterscripts > Includes

Reply
 
Thread Tools Display Modes
Old 16/02/2019, 09:43 AM   #171
Switel12
Banned
 
Join Date: Dec 2017
Location: Poland
Posts: 10
Reputation: 4
Default Re: 3DTryg Functions

Today 3DTryg has been updated to v4.7.0, now FCNPC v2.0.0 is supported.
Download: https://adm.ct8.pl/d/3DTryg.inc
Updates: https://adm.ct8.pl/#updates


Quote:
Originally Posted by NoahAntilles View Post
Thanks for your reply, I forgot to mention this in my previous post but I actually already tried that.
If I remove the version check Pawno simply doesn't compile the script. I get a blank output and an AMX file of 0kb. So that doesn't work either sadly.
Check your include structure:
PHP Code:
#include <Streamer>
#include <ColAndreas>

#include <3DTryg>
#include <Missile>
#include <VehicleMissileCol> 
Never remove version check and other check because this prevent compiler some warnings/errors/crashes.
Switel12 is offline   Reply With Quote
Old 16/02/2019, 10:14 AM   #172
BigETI
Banned
 
Join Date: Mar 2010
Location: Germany
Posts: 1,055
Reputation: 359
Default Re: 3DTryg Functions

Did you set up any unit tests yet?
BigETI is offline   Reply With Quote
Old 16/02/2019, 11:29 AM   #173
Switel12
Banned
 
Join Date: Dec 2017
Location: Poland
Posts: 10
Reputation: 4
Default Re: 3DTryg Functions

Include has been tested by standard test script with use all functions, no warning and errors.
Switel12 is offline   Reply With Quote
Old 16/02/2019, 03:57 PM   #174
BigETI
Banned
 
Join Date: Mar 2010
Location: Germany
Posts: 1,055
Reputation: 359
Default Re: 3DTryg Functions

Nice test script https://github.com/AbyssMorgan/3DTry...aster/test.pwn

If it compiles fine then it doesn't mean that it is also semantically correct.
BigETI is offline   Reply With Quote
Old 17/02/2019, 05:54 AM   #175
Switel12
Banned
 
Join Date: Dec 2017
Location: Poland
Posts: 10
Reputation: 4
Default Re: 3DTryg Functions

Quote:
Originally Posted by BigETI View Post
Nice test script https://github.com/AbyssMorgan/3DTry...aster/test.pwn

If it compiles fine then it doesn't mean that it is also semantically correct.

This is not correct test script, now AbyssMorgan uploaded right test.
Switel12 is offline   Reply With Quote
Old 17/02/2019, 06:42 AM   #176
Double-O-Seven
Little Clucker
 
Double-O-Seven's Avatar
 
Join Date: Jan 2012
Posts: 49
Reputation: 35
Default Re: 3DTryg Functions

But it doesn’t have any assertions in the test script or am I blind?
Just because it compiles and doesn’t give you any warnings doesn’t mean that logic is correct.
Double-O-Seven is offline   Reply With Quote
Old 17/02/2019, 07:27 AM   #177
Switel12
Banned
 
Join Date: Dec 2017
Location: Poland
Posts: 10
Reputation: 4
Default Re: 3DTryg Functions

Quote:
Originally Posted by The King's Bastard View Post
But it doesn’t have any assertions in the test script or am I blind?
Just because it compiles and doesn’t give you any warnings doesn’t mean that logic is correct.

The logic was tested when the function was created, after the successful test an update was issued and the test code was deleted.

The "Fuze Test" test script applies to the compiler test to avoid simple errors with mass fixes.
Example: After syntax update
Switel12 is offline   Reply With Quote
Old 17/02/2019, 08:50 AM   #178
BigETI
Banned
 
Join Date: Mar 2010
Location: Germany
Posts: 1,055
Reputation: 359
Default Re: 3DTryg Functions

Please add semantics checks to your test script.

You can use y_test to create an unit test. More about that is available at sampctl wiki and YSI documentation.
BigETI is offline   Reply With Quote
Old 19/02/2019, 05:50 AM   #179
Switel12
Banned
 
Join Date: Dec 2017
Location: Poland
Posts: 10
Reputation: 4
Default Re: 3DTryg Functions

Quote:
Originally Posted by BigETI View Post
Please add semantics checks to your test script.

You can use y_test to create an unit test. More about that is available at sampctl wiki and YSI documentation.
Answer Abyss Morgan sound as follows:

Quote:
Do you think I will use any includs from ******?
Switel12 is offline   Reply With Quote
Old 19/02/2019, 11:23 AM   #180
BigETI
Banned
 
Join Date: Mar 2010
Location: Germany
Posts: 1,055
Reputation: 359
Default Re: 3DTryg Functions

It's a convenient library. You don't have to include the entire YSI library just for y_test. If you don't use y_test because of personal issues with ****** (for example re-releasing his work and adding your own name to the credits and getting reported by him because of that) then it is absolutely fine not to use y_test. You should design your tests properly. There are no assertion functions in your test script. Again if it compiles fine, that does NOT mean it is semantically correct.
BigETI is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
[Include] [INC] LSF - Lorenc's Simple Functions (w/ gang/clan functions) Lorenc_ Includes 14 21/04/2018 04:06 AM
What is the difference between public functions and stock functions? NeskWriter Scripting Help 1 16/10/2013 06:23 PM
File Functions + String Functions NoaM[W] Scripting Help 2 19/12/2012 08:13 PM
Pawno functions Doesn't Show on the functions Tab silvan Scripting Help 2 11/11/2012 09:42 AM
[Tool/Web/Other] Cross Functions V1.0 - Create Custom Call Backs / Functions by Just 1 Click CROSS_Hunter Tools and Files 7 05/11/2012 02:17 PM


All times are GMT. The time now is 06:17 AM.


Powered by vBulletin® Version 3.8.6
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.