SA-MP Forums

Go Back   SA-MP Forums > SA-MP Scripting and Plugins > Filterscripts

Reply
 
Thread Tools Display Modes
Old 16/09/2018, 12:09 PM   #21
Broly311
Banned
 
Join Date: Sep 2018
Location: Pakistan , Rawalpindi , Adyala Road
Posts: 2
Reputation: 1
Default Re: Donor System

Thank you +rep
Broly311 is offline   Reply With Quote
Old 27/09/2018, 11:23 AM   #22
Yourbirth
Little Clucker
 
Join Date: Sep 2018
Posts: 2
Reputation: 0
Default Re: Donor System

the best and simple system i saw +REP
Yourbirth is offline   Reply With Quote
Old 27/09/2018, 11:43 AM   #23
Yourbirth
Little Clucker
 
Join Date: Sep 2018
Posts: 2
Reputation: 0
Thumbs up Re: Donor System

Best and simple vip system +REP
Yourbirth is offline   Reply With Quote
Old 27/09/2018, 01:01 PM   #24
Logic_
High-roller
 
Logic_'s Avatar
 
Join Date: Jun 2015
Location: 666
Posts: 1,497
Reputation: 273
Default Re: Donor System

As RogueDrifter said, your filterscript is not GOOD.

Now don't take mine or his words as a word of discouragement but instead, take them as words of encouragements and pure constructive criticism. Let's start with the script and make notes of what needs to be changed/ improved:

1. Enumeration

Code:
enum pData
{
	God,
	Maptp,
	dlvl
};
Here your enumeration is FINE but you're not following the naming convention and this can cause confusion.
Since enumeration just make it easier to remember the "slots" of an array - you should name them the same way,
if "God" has the first letter capital than "dlvl" should also have it's first letter capitalized.

Although, generally this technique is used by you for variables, I'll recommend you to make them all CAPITAL.
GOD, MAPTP and DLVL but they are still vaguely named and don't represent they are used in an enumeration - you can add the prefix based on the enumerator's name.

This is how you should do it:
Code:
enum p_DonorData {
	DONOR_GOD,
	DONOR_MAPTP,
	DONOR_LEVEL
};
I'm not telling you to copy my exact method but take a look at the names of the enumerator and its content:

p_DonorData = "p" is the prefix I use for Player related content and DonorData represents what it says! This is based of Hungarain Notation but with my own touch.

The enumerator content is in CAPITALS because that's how I name my constant values.

Although my explanation and pointing out can take a few posts - I'll suggest you to focus on our words who want you to improve NOT the words of others who just want you to figure things out yourself or not improve at all.

At last, I'll quote my words from another post:

Quote:
Originally Posted by Logic_ View Post
Don't consider wasting your time for better of other people who don't want to change themselves or their code.

"You can lead a horse to water, but you can't make it drink" - Remember that.
If you don't improve or change yourself with the criticism you get, don't release your shit here.
__________________
Feeling like a pawn to the greed of these fools
But I never been a piece of the evil
Logic_ is offline   Reply With Quote
Old 27/09/2018, 03:36 PM   #25
NikhilMeena
Little Clucker
 
NikhilMeena's Avatar
 
Join Date: Sep 2018
Location: India
Posts: 11
Reputation: 7
Default Re: Donor System

Logic this is my first script and i am trying to make it much better

I just started scripting so i not learn too much in scripting
__________________
My Work
[SIZE="2"][FilterScript]Tricky Donor System

Donate
Donate me to improve my skills 😀
NikhilMeena is offline   Reply With Quote
Old 27/09/2018, 07:48 PM   #26
RogueDrifter
High-roller
 
RogueDrifter's Avatar
 
Join Date: Dec 2017
Location: SA-MP Drifting world.
Posts: 1,170
Reputation: 351
Default Re: Donor System

Quote:
Originally Posted by NikhilMeena View Post
Logic this is my first script and i am trying to make it much better

I just started scripting so i not learn too much in scripting
Observe and learn here, trust me we are not posting these comments and taking time out of our lives just for the fuck of it mate, you see, when i myself first started scripting reading wrongly written releases at first got me to not use proper indentation on my code and use wrong methods which lead to delayments of me improving on scripting.

Now people reading yours will encounter the same problem i had, do you see where i'm going? If anything a warning should've been posted on the main thread, so that others wouldn't follow the badly written code parts.
__________________

[Github]:Link [Gists]:Link [Forum]:Link [Server]:Link [Discord]:Link


RogueDrifter is offline   Reply With Quote
Old 27/09/2018, 08:35 PM   #27
NoorMustafa123
Little Clucker
 
NoorMustafa123's Avatar
 
Join Date: May 2017
Location: idk
Posts: 32
Reputation: 6
Default Re: Donor System

guys, you're acting like once u had started scripting, u was gods lmao, all of u had shitty releases, so this ain't bad for a newbie in scriping. anyway good job, keep it up.
__________________
My Works
[Maps] Area 51 | Desert Airport | A Small Island |
NoorMustafa123 is offline   Reply With Quote
Old 28/09/2018, 04:35 AM   #28
KayJ
Gangsta
 
Join Date: Apr 2014
Posts: 703
Reputation: 64
Default Re: Donor System

According to above conversation, I think person shouldn't post anything unless it's different from other to prevent same system scripts again and again... Instead if they made something which already exist on forum then they should keep to themselves.
__________________
SA:MP Wikipedia Profile

[Filterscript] Wallet + Robbery [Y_INI] [ZCMD] [BETA v0.1]
[Filterscript] Position - Save, Load & Delete [Y_INI] [ZCMD]
[Include] InfoText TextDraw
KayJ is offline   Reply With Quote
Old 28/09/2018, 08:35 AM   #29
Danielknow
Big Clucker
 
Join Date: May 2018
Location: United States
Posts: 57
Reputation: 1
Default Re: Donor System

nice.
Danielknow is offline   Reply With Quote
Old 28/09/2018, 10:37 AM   #30
Venom546
Big Clucker
 
Venom546's Avatar
 
Join Date: Sep 2018
Posts: 51
Reputation: 0
Default Re: Donor System

coooool..
__________________


join us now we have hosted tab
our hosted forums : http://ggw-gaming.is-great.net/
so what are u waiting for join us now
Venom546 is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
donor cap Xviper1234 Scripting Help 2 14/03/2015 01:48 PM
not DONOR but can choose donor class PowerF Scripting Help 3 26/01/2015 03:08 PM
[FilterScript] mzAdmin - Admin/Donor System | 20+ Admin Commands [v1] mobiliz Filterscripts 11 28/05/2014 10:39 AM
[FilterScript] Donor System [VIP system] 5 Ranks Zcmd V1.0 RafaelZam Filterscripts 10 23/12/2013 07:04 AM
Donor points system filterscript [COD5]DarKnight Scripting Help 10 05/09/2012 10:21 PM


All times are GMT. The time now is 06:05 PM.


Powered by vBulletin® Version 3.8.6
Copyright ©2000 - 2018, Jelsoft Enterprises Ltd.