SA-MP Forums

Go Back   SA-MP Forums > SA-MP Scripting and Plugins > Filterscripts

Reply
 
Thread Tools Display Modes
Old 07/07/2018, 02:47 PM   #11
Exhibit
Big Clucker
 
Join Date: Dec 2015
Location: Pakistan
Posts: 180
Reputation: 22
Default Re: Discord Admin Control Panel - Manage players through discord!

Quote:
Originally Posted by RogueDrifter View Post
Do you mind putting up a pastebin/github link?
I've added a pastebin link.
Exhibit is offline   Reply With Quote
Old 07/07/2018, 07:19 PM   #12
RogueDrifter
High-roller
 
RogueDrifter's Avatar
 
Join Date: Dec 2017
Location: SA-MP Drifting world.
Posts: 1,193
Reputation: 420
Default Re: Discord Admin Control Panel - Manage players through discord!

U should change this:
Code:
    for(new i=0; i < MAX_PLAYERS; i++) {
    GetPlayerName(i, name, MAX_PLAYER_NAME);
    if(!IsPlayerConnected(i)) continue;
To this:
Code:
    for(new i=0; i < MAX_PLAYERS; i++) {
    if(!IsPlayerConnected(i)) continue;
    GetPlayerName(i, name, MAX_PLAYER_NAME);

Also do you realize that this:
Code:
    for(new i=0; i < MAX_PLAYERS; i++) {
    GetPlayerName(i, name, MAX_PLAYER_NAME);
    if(!IsPlayerConnected(i)) continue;
    SendDC(CHANNEL_ID, "```%s(%d)```", name, i); }
Is going to send 500 discord messages if the server is busy enough? I'd suggest grouping it all up in one string and sending one message or at least do so by checking the amount of online players?

One last thing is this:
Code:
GetPlayerName(giveplayerid, giveplayer, MAX_PLAYER_NAME);
It is for the best always using the sizeof the varible you're storing the name in regardless if MAX_PLAYER_NAME is the same just for compatibility cautiousness in this case and all other cases seeing as if the size of that variable's array ever changes it will lead into problems.

Nevertheless, there isn't much to look at seeing as its a small script, it's a cool idea lots of the effort done was put into the include&plugin that's for sure but it's different so good job to you, Inn0cent and maddinat0r.
__________________
Quote:
Originally Posted by Andy
My anti cheat is still relevant *puts shades on* https://github.com/RogueDrifter/Anti_cheat_pack

[Github]:Link [Gists]:Link [Forum]:Link [Server]:Link [Discord]:Link

RogueDrifter is offline   Reply With Quote
Old 07/07/2018, 08:17 PM   #13
Exhibit
Big Clucker
 
Join Date: Dec 2015
Location: Pakistan
Posts: 180
Reputation: 22
Default Re: Discord Admin Control Panel - Manage players through discord!

Quote:
Originally Posted by RogueDrifter View Post
U should change this:
Code:
    for(new i=0; i < MAX_PLAYERS; i++) {
    GetPlayerName(i, name, MAX_PLAYER_NAME);
    if(!IsPlayerConnected(i)) continue;
To this:
Code:
    for(new i=0; i < MAX_PLAYERS; i++) {
    if(!IsPlayerConnected(i)) continue;
    GetPlayerName(i, name, MAX_PLAYER_NAME);

Also do you realize that this:
Code:
    for(new i=0; i < MAX_PLAYERS; i++) {
    GetPlayerName(i, name, MAX_PLAYER_NAME);
    if(!IsPlayerConnected(i)) continue;
    SendDC(CHANNEL_ID, "```%s(%d)```", name, i); }
Is going to send 500 discord messages if the server is busy enough? I'd suggest grouping it all up in one string and sending one message or at least do so by checking the amount of online players?

One last thing is this:
Code:
GetPlayerName(giveplayerid, giveplayer, MAX_PLAYER_NAME);
It is for the best always using the sizeof the varible you're storing the name in regardless if MAX_PLAYER_NAME is the same just for compatibility cautiousness in this case and all other cases seeing as if the size of that variable's array ever changes it will lead into problems.

Nevertheless, there isn't much to look at seeing as its a small script, it's a cool idea lots of the effort done was put into the include&plugin that's for sure but it's different so good job to you, Inn0cent and maddinat0r.
I appreciate you pointing out my mistakes, It is always better to learn.
Exhibit is offline   Reply With Quote
Old 08/07/2018, 05:01 AM   #14
Akeem
Big Clucker
 
Join Date: Aug 2017
Location: Guyana
Posts: 96
Reputation: 0
Default Re: Discord Admin Control Panel - Manage players through discord!

i can't seem to get this to work
Akeem is offline   Reply With Quote
Old 08/07/2018, 09:51 AM   #15
Exhibit
Big Clucker
 
Join Date: Dec 2015
Location: Pakistan
Posts: 180
Reputation: 22
Default Re: Discord Admin Control Panel - Manage players through discord!

Quote:
Originally Posted by Akeem View Post
i can't seem to get this to work
Contact me on discord. Inferno#7135
Exhibit is offline   Reply With Quote
Old 28/07/2018, 03:15 PM   #16
Exhibit
Big Clucker
 
Join Date: Dec 2015
Location: Pakistan
Posts: 180
Reputation: 22
Default Re: Discord Admin Control Panel - Manage players through discord!

v0.2
Just a few optimizations with the players command.
Exhibit is offline   Reply With Quote
Old 28/07/2018, 09:23 PM   #17
Ogisa
Little Clucker
 
Join Date: Feb 2018
Location: Serbia
Posts: 1
Reputation: 0
Default Re: Discord Admin Control Panel - Manage players through discord!

Good job.
Ogisa is offline   Reply With Quote
Old 19/08/2018, 01:54 AM   #18
AzaMx
Huge Clucker
 
Join Date: Aug 2014
Location: Malaysia
Posts: 333
Reputation: 65
Default Re: Discord Admin Control Panel - Manage players through discord!

When I compiled, I get this warning?

warning 203: symbol is never used: "players"
AzaMx is offline   Reply With Quote
Old 15/09/2018, 09:35 AM   #19
Danielknow
Big Clucker
 
Join Date: May 2018
Location: United States
Posts: 83
Reputation: 1
Default Re: Discord Admin Control Panel - Manage players through discord!

Amazing work! i using it now on my server
Admin console + chat its amazing.
Danielknow is offline   Reply With Quote
Old 15/09/2018, 02:54 PM   #20
NikhilMeena
Banned
 
Join Date: Sep 2018
Location: India
Posts: 6
Reputation: 7
Default Re: Discord Admin Control Panel - Manage players through discord!

Rouge they already putted a pastebin and solidfiles link

And good work keep it up
NikhilMeena is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
[FilterScript] Discord Chat - Real time chatting ( Discord + In Game) Exhibit Filterscripts 36 16/10/2019 08:32 PM
Discord Help baki Scripting Help 4 09/08/2017 10:28 PM


All times are GMT. The time now is 08:49 PM.


Powered by vBulletin® Version 3.8.6
Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.