SA-MP Forums

Go Back   SA-MP Forums > SA-MP > Bug Reports

Reply
 
Thread Tools Display Modes
Old 15/09/2015, 07:00 PM   #1
Patchwerk
Big Clucker
 
Join Date: Jul 2011
Location: Slovakia
Posts: 80
Reputation: 19
Default Server crash when destroyvehicle

Hi,

I find hidden bug. When I destroy vehicle in OnVehicleDeath there is chance to crash a server.

Code:
Code:
hook OnVehicleDeath(vehicleid, killerid){
	Debug(DBG_CORE, "Vehicle/Core.pwn","OnVehicleDeath(%d,%d)",vehicleid,killerid);
	foreach(new car : Vehicles){
		if(Vehicles[car][ID] == vehicleid){
			printf("%d == %d", Vehicles[car][ID], vehicleid);
			DestroyVehicle(vehicleid);
			veh_Locked[vehicleid] = INVALID_PLAYER_ID;
			defer ReCreateCar(car);
		}
	}
}

timer ReCreateCar[2500](car)
{ 
	new type = Vehicles[car][Type];
	Vehicles[type][Color][0] = random(255);
	Vehicles[type][Color][1] = random(255);
	new rand = random(VehicleCategorySize[type]);
	printf("ReCreateCar(%d), type = %d, rand = %d", car, type, rand);
	Vehicles[car][ID] = CreateVehicle(VehicleCategory[type][rand], Vehicles[car][Pos][0], Vehicles[car][Pos][1], Vehicles[car][Pos][2], Vehicles[car][Pos][3], Vehicles[car][Color][0], Vehicles[car][Color][1], 120);
	printf("ReCreateCar(%d), type = %d, rand = %d", car, type, rand);
	veh_Traveled[Vehicles[car][ID]] = randomEx(0,200000);
	if(!Vehicle_IsManual(Vehicles[car][ID])){
		SetVehicleFuel(Vehicles[car][ID], RandomFloat(3.0, GetModelMaxFuel(VehicleCategory[type][rand]), 2) );
		print("SetVehicleParams");
		SetVehicleParamsEx(Vehicles[car][ID],0,0,0,0,0,0,0);
	}
}
LOG:
Code:
[20:47:59] Vehicle/Core.pwn -> OnVehicleDeath(7,0)
[20:47:59] 7 == 7
[20:48:02] ReCreateCar(6), type = 8, rand = 23
[20:48:02] ReCreateCar(6), type = 8, rand = 23
[20:48:02] SetVehicleParams
[20:48:12] Vehicle/Core.pwn -> OnVehicleDeath(7,0)
[20:48:12] 7 == 7
[20:48:15] ReCreateCar(6), type = 8, rand = 15
[20:48:15] ReCreateCar(6), type = 8, rand = 15
[20:48:15] SetVehicleParams
[20:48:24] Vehicle/Core.pwn -> OnVehicleDeath(7,4)
[20:48:24] 7 == 7
[20:48:27] ReCreateCar(6), type = 8, rand = 4
[20:48:27] ReCreateCar(6), type = 8, rand = 4
[20:48:27] SetVehicleParams
[20:48:32] Vehicle/Core.pwn -> OnVehicleDeath(7,0)
[20:48:32] 7 == 7
[20:48:35] ReCreateCar(6), type = 8, rand = 3
[20:48:35] ReCreateCar(6), type = 8, rand = 3
[20:48:35] SetVehicleParams
[20:48:47] Vehicle/Core.pwn -> OnVehicleDeath(7,0)
[20:48:47] 7 == 7
[20:48:50] ReCreateCar(6), type = 8, rand = 18
[20:48:50] ReCreateCar(6), type = 8, rand = 18
[20:48:50] SetVehicleParams
[20:49:13] Vehicle/Core.pwn -> OnVehicleDeath(7,0)
[20:49:13] 7 == 7
[20:49:16] ReCreateCar(6), type = 8, rand = 18
[20:49:16] ReCreateCar(6), type = 8, rand = 18
[20:49:16] SetVehicleParams
[20:49:30] Vehicle/Core.pwn -> OnVehicleDeath(7,0)
[20:49:30] 7 == 7
[20:49:33] ReCreateCar(6), type = 8, rand = 17
[20:49:33] ReCreateCar(6), type = 8, rand = 17
[20:49:33] SetVehicleParams
[20:49:46] Vehicle/Core.pwn -> OnVehicleDeath(7,4)
[20:49:46] 7 == 7
[20:49:49] ReCreateCar(6), type = 8, rand = 32
[20:49:49] ReCreateCar(6), type = 8, rand = 32
[20:49:49] SetVehicleParams
[20:50:02] Vehicle/Core.pwn -> OnVehicleDeath(7,4)
[20:50:02] 7 == 7
[20:50:05] ReCreateCar(6), type = 8, rand = 24
[20:50:05] ReCreateCar(6), type = 8, rand = 24
[20:50:05] SetVehicleParams
[20:50:18] Vehicle/Core.pwn -> OnVehicleDeath(7,4)
[20:50:18] 7 == 7
[20:50:21] ReCreateCar(6), type = 8, rand = 28
[20:50:21] ReCreateCar(6), type = 8, rand = 28
[20:50:21] SetVehicleParams
[20:50:34] Vehicle/Core.pwn -> OnVehicleDeath(7,4)
[20:50:34] 7 == 7
[20:50:37] ReCreateCar(6), type = 8, rand = 13
[20:50:37] ReCreateCar(6), type = 8, rand = 13
[20:50:37] SetVehicleParams
[20:50:52] Vehicle/Core.pwn -> OnVehicleDeath(7,4)
[20:50:52] 7 == 7
[20:50:55] ReCreateCar(6), type = 8, rand = 26
[20:50:55] ReCreateCar(6), type = 8, rand = 26
[20:50:55] SetVehicleParams
[20:51:10] Vehicle/Core.pwn -> OnVehicleDeath(7,4)
[20:51:10] 7 == 7
[20:51:13] ReCreateCar(6), type = 8, rand = 2
[20:51:13] ReCreateCar(6), type = 8, rand = 2
[20:51:13] SetVehicleParams
[20:51:28] Vehicle/Core.pwn -> OnVehicleDeath(7,4)
[20:51:28] 7 == 7
[20:51:31] ReCreateCar(6), type = 8, rand = 31
[20:51:31] ReCreateCar(6), type = 8, rand = 31
[20:51:31] SetVehicleParams
[20:51:38] Vehicle/Core.pwn -> OnVehicleDeath(21,0)
[20:51:38] 21 == 21
[20:51:41] ReCreateCar(20), type = 6, rand = 8
[20:51:41] ReCreateCar(20), type = 6, rand = 8
[20:51:41] SetVehicleParams
[20:51:55] Vehicle/Core.pwn -> OnVehicleDeath(7,4)
[20:51:55] 7 == 7
[20:51:58] [debug] Server crashed due to an unknown error
[20:51:58] [debug] Native backtrace:
[20:51:58] [debug] #0 f7407e8b in _ZN10StackTraceC1EPv () from plugins/crashdetect.so
[20:51:58] [debug] #1 f7400bcf in _ZN11CrashDetect20PrintNativeBacktraceERSoPv () from plugins/crashdetect.so
[20:51:58] [debug] #2 f7401dbc in _ZN11CrashDetect20PrintNativeBacktraceEPv () from plugins/crashdetect.so
[20:51:58] [debug] #3 f7402226 in _ZN11CrashDetect11OnExceptionEPv () from plugins/crashdetect.so
[20:51:58] [debug] #4 f7407adc in ?? () from plugins/crashdetect.so
[20:51:58] [debug] #5 f76e8410 in ?? ()
[20:51:58] [debug] #6 0809568a in ?? () from ./7777svr
[20:51:58] [debug] #7 080957cd in ?? () from ./7777svr
[20:51:58] [debug] #8 f63975b4 in ?? () from plugins/streamer.so
[20:51:58] [debug] #9 080ebba0 in ?? () from ./7777svr
[20:51:58] [debug] #10 080af03c in ?? () from ./7777svr
[20:51:58] [debug] #11 080aa13a in ?? () from ./7777svr
[20:51:58] [debug] #12 f7442e46 in __libc_start_main () from /lib/i386-linux-gnu/i686/cmov/libc.so.6
[20:51:58] [debug] #13 0804b4e1 in ?? () from ./7777svr

Can someone confirm this bug? We destroy about 50 vehicles before crash.

Cheers

Last edited by Patchwerk; 15/09/2015 at 08:12 PM.
Patchwerk is offline   Reply With Quote
Old 15/09/2015, 07:13 PM   #2
][Noname][
Gangsta
 
][Noname]['s Avatar
 
Join Date: Dec 2010
Posts: 623
Reputation: 92
Default Re: Server crash when destroyvehicle

confirm
__________________
Owner of Absolute Play and SAMP Addon
][Noname][ is offline   Reply With Quote
Old 15/09/2015, 07:30 PM   #3
IstuntmanI
High-roller
 
IstuntmanI's Avatar
 
Join Date: Mar 2009
Location: Romania
Posts: 1,832
Reputation: 375
Default Re: Server crash when destroyvehicle

Also, if we try to disable the vehicle objective under OnVehicleDeath with SetVehicleParamsEx, it will not disappear until respawn.
__________________


IstuntmanI is offline   Reply With Quote
Old 15/09/2015, 11:12 PM   #4
][Noname][
Gangsta
 
][Noname]['s Avatar
 
Join Date: Dec 2010
Posts: 623
Reputation: 92
Default Re: Server crash when destroyvehicle

is there something with restart?

Quote:
[20:51:55] 7 == 7
[20:51:58] [debug] Server crashed due to an unknown error
3 seconds after
__________________
Owner of Absolute Play and SAMP Addon
][Noname][ is offline   Reply With Quote
Old 18/11/2016, 09:43 PM   #5
cawfee
Little Clucker
 
cawfee's Avatar
 
Join Date: Oct 2011
Location: United States
Posts: 23
Reputation: 27
Default Re: Server crash when destroyvehicle

Confirmed (been over a year now... I know)
__________________
cawfee is offline   Reply With Quote
Old 03/09/2018, 02:26 PM   #6
NeXTGoD
Big Clucker
 
NeXTGoD's Avatar
 
Join Date: Jul 2018
Posts: 65
Reputation: 4
Default Re: Server crash when destroyvehicle

This bug is still affecting my server very badly version 0.3.7-R2

is there any fix for it
__________________
.

xSF Reborn:


.
NeXTGoD is online now   Reply With Quote
Old 03/09/2018, 05:05 PM   #7
RogueDrifter
High-roller
 
RogueDrifter's Avatar
 
Join Date: Dec 2017
Location: SA-MP Drifting world.
Posts: 1,180
Reputation: 384
Default Re: Server crash when destroyvehicle

Quote:
Originally Posted by NeXTGoD View Post
This bug is still affecting my server very badly version 0.3.7-R2

is there any fix for it
Don't destroy vehicles under OnVehicleDeath??
__________________
Quote:
Originally Posted by Andy
I offer paid scripting services, I can do anything except mapping because fuck mapping.

[Github]:Link [Gists]:Link [Forum]:Link [Server]:Link [Discord]:Link


RogueDrifter is offline   Reply With Quote
Old 03/09/2018, 05:53 PM   #8
NeXTGoD
Big Clucker
 
NeXTGoD's Avatar
 
Join Date: Jul 2018
Posts: 65
Reputation: 4
Default Re: Server crash when destroyvehicle

Quote:
Originally Posted by RogueDrifter View Post
Don't destroy vehicles under OnVehicleDeath??
Nope, the public is empty
__________________
.

xSF Reborn:


.
NeXTGoD is online now   Reply With Quote
Old 03/09/2018, 06:00 PM   #9
RogueDrifter
High-roller
 
RogueDrifter's Avatar
 
Join Date: Dec 2017
Location: SA-MP Drifting world.
Posts: 1,180
Reputation: 384
Default Re: Server crash when destroyvehicle

Quote:
Originally Posted by NeXTGoD View Post
Nope, the public is empty
Show server logs using crashdetect.
__________________
Quote:
Originally Posted by Andy
I offer paid scripting services, I can do anything except mapping because fuck mapping.

[Github]:Link [Gists]:Link [Forum]:Link [Server]:Link [Discord]:Link


RogueDrifter is offline   Reply With Quote
Old 03/09/2018, 06:43 PM   #10
NeXTGoD
Big Clucker
 
NeXTGoD's Avatar
 
Join Date: Jul 2018
Posts: 65
Reputation: 4
Default Re: Server crash when destroyvehicle

Quote:
Originally Posted by RogueDrifter View Post
Show server logs using crashdetect.
Code:
[03/09/2018 16:05:40] OnPlayerSpawn(1)
[03/09/2018 16:05:40] CountdownPlayer(1,3)
[03/09/2018 16:05:43] OnVehicleDeath(4)
[03/09/2018 16:05:43] CountdownPlayer(1,2)
[03/09/2018 16:05:43] [debug] Server crashed due to an unknown error
[03/09/2018 16:05:44] [debug] Native backtrace:
[03/09/2018 16:05:44] [debug] #0 b7355ed6 in _Z13GetStackTraceRSt6vectorI10StackFrameSaIS0_EEPv () from plugins/crashdetect.so
[03/09/2018 16:05:44] [debug] #1 b734e210 in _ZN18CrashDetectHandler20PrintNativeBacktraceERSoRKN2os7ContextE () from plugins/crashdetect.so
[03/09/2018 16:05:44] [debug] #2 b734f05c in _ZN18CrashDetectHandler20PrintNativeBacktraceERKN2os7ContextE () from plugins/crashdetect.so
[03/09/2018 16:05:44] [debug] #3 b734fbb6 in _ZN18CrashDetectHandler7OnCrashERKN2os7ContextE () from plugins/crashdetect.so
[03/09/2018 16:05:44] [debug] #4 b73555c2 in ?? () from plugins/crashdetect.so
[03/09/2018 16:05:44] [debug] #5 b76fe600 in __kernel_rt_sigreturn () from linux-gate.so.1
[03/09/2018 16:05:44] [debug] #6 0814b4bc in ?? () from ./samp8888_6551
[03/09/2018 16:05:44] [debug] #7 0814cccf in ?? () from ./samp8888_6551
[03/09/2018 16:05:44] [debug] #8 080af078 in ?? () from ./samp8888_6551
[03/09/2018 16:05:44] [debug] #9 080aa13a in ?? () from ./samp8888_6551
[03/09/2018 16:05:44] [debug] #10 b7396723 in __libc_start_main () from /lib/i386-linux-gnu/libc.so.6
[03/09/2018 16:05:44] [debug] #11 0804b4e1 in ?? () from ./samp8888_6551
[03/09/2018 16:05:44] [debug] Registers:
[03/09/2018 16:05:44] [debug] EAX: 447a0000 EBX: 0a2ff5b0 ECX: 00000000 EDX: c511ac1b
[03/09/2018 16:05:44] [debug] ESI: 00000004 EDI: 0a2ff67b EBP: bfcc5028 ESP: bfcc5000
[03/09/2018 16:05:44] [debug] EIP: 0814b4bc EFLAGS: 00010246
[03/09/2018 16:05:44] [debug] Stack:
[03/09/2018 16:05:44] [debug] ESP+00000000: 0a2ff5bc 00000000 00000040 00000000
[03/09/2018 16:05:44] [debug] ESP+00000020: 00000002 0a37cf18 bfcc5048 0814cccf
[03/09/2018 16:05:44] [debug] ESP+00000040: 00000000 08159c53 bfcc5078 080af078
[03/09/2018 16:05:44] [debug] ESP+00000060: 081a18b4 00000000 00000000 004c4b40
[03/09/2018 16:05:44] [debug] ESP+00000080: 0a168e78 08159c53 00000006 08159c6d
[03/09/2018 16:05:44] [debug] ESP+000000a0: bfcc50bc b76646d6 b76c8000 b76302f3
[03/09/2018 16:05:44] [debug] ESP+000000c0: 00010000 000022b8 00000032 0163044b
[03/09/2018 16:05:44] [debug] ESP+000000e0: b76c8000 b76c8000 b76c95a0 b75d60a9
[03/09/2018 16:05:44] [debug] ESP+00000100: 080494b0 b76c9784 b74edd64 081a1880
[03/09/2018 16:05:44] [debug] ESP+00000120: 00000000 00000000 00000000 00000000
[03/09/2018 16:05:44] [debug] ESP+00000140: 00000000 00000000 00000000 00000000
[03/09/2018 16:05:44] [debug] ESP+00000160: 00000000 00000000 00000000 00000000
[03/09/2018 16:05:44] [debug] ESP+00000180: 00000000 00000000 00000000 00000000
[03/09/2018 16:05:44] [debug] ESP+000001a0: b74ed3a4 b7720000 081505cb b74ed000
[03/09/2018 16:05:44] [debug] ESP+000001c0: 00000001 bfcc5254 bfcc525c b770de9a
[03/09/2018 16:05:44] [debug] ESP+000001e0: 080494b0 b74ed000 00000000 00000000
[03/09/2018 16:05:44] [debug] ESP+00000200: 00000000 00000000 00000001 0804b4c0
[03/09/2018 16:05:44] [debug] ESP+00000220: 00000001 0804b4c0 00000000 0804b4e1
[03/09/2018 16:05:44] [debug] ESP+00000240: 081505b0 b770e350 bfcc524c 0000001c
[03/09/2018 16:05:44] [debug] ESP+00000260: bfcc5eb1 bfcc5ec1 bfcc5ee6 bfcc5ef0
[03/09/2018 16:05:44] [debug] ESP+00000280: bfcc5f62 bfcc5f6f bfcc5fa6 bfcc5fc5
[03/09/2018 16:05:44] [debug] ESP+000002a0: 00000021 b76fe000 00000010 bfebfbff
[03/09/2018 16:05:44] [debug] ESP+000002c0: 00000003 08048034 00000004 00000020
[03/09/2018 16:05:44] [debug] ESP+000002e0: 00000008 00000000 00000009 0804b4c0
[03/09/2018 16:05:44] [debug] ESP+00000300: 0000000d 000003e8 0000000e 000003e8
[03/09/2018 16:05:44] [debug] ESP+00000320: 0000001f bfcc5fe8 0000000f bfcc534b
[03/09/2018 16:05:44] [debug] ESP+00000340: c40c55b9 d0b79f9a 6964cb19 00363836
[03/09/2018 16:05:44] [debug] ESP+00000360: 00000000 00000000 00000000 00000000
[03/09/2018 16:05:44] [debug] ESP+00000380: 00000000 00000000 00000000 00000000
[03/09/2018 16:05:44] [debug] ESP+000003a0: 00000000 00000000 00000000 00000000
[03/09/2018 16:05:44] [debug] ESP+000003c0: 00000000 00000000 00000000 00000000
[03/09/2018 16:05:44] [debug] ESP+000003e0: 00000000 00000000 00000000 00000000
[03/09/2018 16:05:44] [debug] Loaded modules:
[03/09/2018 16:05:44] [debug] 00000000 - 00187d1f samp8888_6551
[03/09/2018 16:05:44] [debug] b7700000 - b7700704 linux-gate.so.1
[03/09/2018 16:05:44] [debug] b76e8000 - b76ea81f /lib/i386-linux-gnu/libdl.so.2
[03/09/2018 16:05:44] [debug] b76cd000 - b76e72f3 /lib/i386-linux-gnu/libpthread.so.0
[03/09/2018 16:05:44] [debug] b7553000 - b76d63b3 /usr/lib/i386-linux-gnu/libstdc++.so.6
[03/09/2018 16:05:44] [debug] b750e000 - b7551ab7 /lib/i386-linux-gnu/libm.so.6
[03/09/2018 16:05:44] [debug] b74f1000 - b750d3c4 /lib/i386-linux-gnu/libgcc_s.so.1
[03/09/2018 16:05:44] [debug] b737d000 - b74f8ddb /lib/i386-linux-gnu/libc.so.6
[03/09/2018 16:05:44] [debug] b76ff000 - b771fd6c /lib/ld-linux.so.2
[03/09/2018 16:05:44] [debug] b7337000 - b7378e08 plugins/crashdetect.so
[03/09/2018 16:05:44] [debug] b7272000 - b7336bcf plugins/streamer.so
[03/09/2018 16:05:44] [debug] b76f2000 - b76f9093 /lib/i386-linux-gnu/librt.so.1
[03/09/2018 16:05:44] [debug] b703b000 - b7278854 plugins/YSF.so
[03/09/2018 16:05:44] [debug] b702e000 - b7039790 plugins/sscanf.so
[03/09/2018 16:05:44] [debug] b7028000 - b702b5d8 plugins/MapAndreas.so
[03/09/2018 16:05:44] [debug] b6fe5000 - b6ff03ef /lib/i386-linux-gnu/libnss_files.so.2
__________________
.

xSF Reborn:


.
NeXTGoD is online now   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Crash detect , server crash Debug. whats wrong? MarwanCartman Server Support 4 10/05/2015 11:14 AM
[HELP]Server Crash - Located crash line with CrashDETECT - Guest4390857394857 Server Support 4 05/09/2014 04:37 AM
DestroyVehicle crash. MP2 Bug Reports 2 24/01/2013 07:02 PM
Fatal Game crash, Not client or server crash SourceCode Scripting Help 3 11/10/2011 05:13 PM
'SERVER: Unknown command' after used DestroyVehicle(); Faust Help Archive 12 25/02/2009 04:16 PM


All times are GMT. The time now is 12:34 PM.


Powered by vBulletin® Version 3.8.6
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.