SA-MP Forums

Go Back   SA-MP Forums > SA-MP Scripting and Plugins > Filterscripts

Reply
 
Thread Tools Display Modes
Old 25/05/2018, 09:54 PM   #1
CaptainBoi
Huge Clucker
 
CaptainBoi's Avatar
 
Join Date: May 2018
Location: Inside Game
Posts: 265
Reputation: 25
Default Perks System (v: [On Update]) [DINI, ZCMD]

Introduction
Well i worked alot on this scrip, i have searched perk system but i didnot got any on sa:mp forum and here my new filterscript of perks system which includes some cool features which i will describe below..

Commands
*/perks (to see availabel perks)
*/setperkpoints (to set your perk points which you have to buy)
*/setperklevel (to set perk [admin command])

Perks
*Untouchable
*Juggernaut
*Recovering
*Shockwave

Uses
*Untouchable: Temporary Invurability
*Juggernaut: Super Heavy Armour
*Recovering: Regenerate Health
*Shockwave: Stun Players

Credits
Code:
/*******************************************************************
 *                                   Credits......                 *
 *																   *
 *																   *
 * >>>>>>>>>>> Don't remove credits..............<<<<<<<<<<<       *
 *																   *
 * >>>>>>>>>>>>Don't release it without my permission...<<<<<<<    *
 *																   *
 * >>>>CaptainBoi: Working on it all the time.. <<<                *
 *																   *
 * >>>>Morken: Helping me... <<<<								   *
 *																   *
 * Includes : <a_samp> | SA:MP  || <sscanf2> |  [well]idk ||<dini> | Dracoblue || <zcmd> | Zeex
 *																   *
 *>>>>>>>>>>>>> Comment Below How Is It.... <<<<<<<<<<<<           *
 *																   *
 ******************************************************************/
Codes
Pastebin

Bugs
*I didnot got any bug yet, if you found report it here.
CaptainBoi is offline   Reply With Quote
Old 27/05/2018, 07:29 AM   #2
CaptainBoi
Huge Clucker
 
CaptainBoi's Avatar
 
Join Date: May 2018
Location: Inside Game
Posts: 265
Reputation: 25
Default Re: Perks System (v: [On Update]) [DINI, ZCMD]

150: views
0: comments

what happen to samp users lol

bump
CaptainBoi is offline   Reply With Quote
Old 27/05/2018, 05:52 PM   #3
jasperschellekens
Gangsta
 
jasperschellekens's Avatar
 
Join Date: Dec 2016
Location: Gehenna
Posts: 689
Reputation: 43
Default Re: Perks System (v: [On Update]) [DINI, ZCMD]

Quote:
Originally Posted by CaptainBoi View Post
150: views
0: comments

what happen to samp users lol

bump
Well simple; Its not worthy to reply on
jasperschellekens is offline   Reply With Quote
Old 27/05/2018, 05:52 PM   #4
Gammix
High-roller
 
Gammix's Avatar
 
Join Date: Jan 2015
Location: Canada
Posts: 1,828
Reputation: 836
Default Re: Perks System (v: [On Update]) [DINI, ZCMD]

Quote:
Originally Posted by jasperschellekens View Post
Well simple; Its not worthy to reply on
Savage!
__________________

Follow me on Github: Follow me on Spotify: Donate on Paypal:

Gammix is online now   Reply With Quote
Old 22/06/2018, 02:48 PM   #5
CaptainBoi
Huge Clucker
 
CaptainBoi's Avatar
 
Join Date: May 2018
Location: Inside Game
Posts: 265
Reputation: 25
Default Re: Perks System (v: [On Update]) [DINI, ZCMD]

i know
__________________
Code:
Releases
[FilterScript] Dynamic MySQL GPS System
[Tutorial] How to make TDM Team Selection.
[Include] moneybar.inc || Coloured Moneybar || Released
[Tutorial] PAWN Compiler In Notepad++
[FilterScript] Perks System (v: [On Update]) [DINI, ZCMD]
[FilterScript] Realistic Transmission Speedometer
CaptainBoi is offline   Reply With Quote
Old 22/06/2018, 03:10 PM   #6
Lokii
Huge Clucker
 
Join Date: Sep 2017
Posts: 312
Reputation: 77
Default Re: Perks System (v: [On Update]) [DINI, ZCMD]

Quote:
Originally Posted by CaptainBoi View Post
i know
nice bump
Lokii is offline   Reply With Quote
Old 22/06/2018, 05:06 PM   #7
RogueDrifter
High-roller
 
RogueDrifter's Avatar
 
Join Date: Dec 2017
Location: SA-MP Drifting world.
Posts: 1,242
Reputation: 379
Default Re: Perks System (v: [On Update]) [DINI, ZCMD]

You want comments? stop bumping this shit and let people decide on their own.

It's a joke, first of all DINI? (I know right i'm the one to talk LOL) BUT I IMPROVED.

Overall, my point is DINI is SLOW, many other ways could've been used other than that and come on i mean 2018 and dini in a whole system isn't just decent, the system itself looks like one of those custom-made ones and hardly fits anywhere if it even works.

This:
PHP Code:
new perkpoints[MAX_PLAYERS];
new 
perks[MAX_PLAYERS][10][5];
new 
perkcd[MAX_PLAYERS][10];
new 
perkregentimer[MAX_PLAYERS];
new 
Float:pmaxhealth[MAX_PLAYERS];
new 
Float:pmaxarmour[MAX_PLAYERS];
new 
Float:phealth[MAX_PLAYERS]; 
Why not group all of that into an enum to make the code look more decent if you're going to use so many player variables?

And the names don't make sense one bit.

Code:
#define accounts "accounts"
Creativity at it's finest lmao.


The code also isn't fully indented and you're leaving unused functions around which is very lazy and annoying.

The whole use of this:
Code:
 dini_Int(FileDirectory(accounts, playername(playerid)), "maxhealth");
Made my eyes bleed a bit, why not create a global variable for the file, open the file then use the variables for gods sake this is destroying the readability even more.

Actually i'm starting to think this is a compilation of shit copy-pasta went wrong, the use of
Code:
phealth[playerid]
...the variable doesn't make any sense at all, scroll through your own code you'll shit yourself and give yourself a few kicks maybe if you even wrote it.

So you created a function to grab a player's name, then you do this:
Code:
                 new pname[MAX_PLAYER_NAME];
                 GetPlayerName(playerid, pname, MAX_PLAYER_NAME);
*facepalm*


And this thing:
PHP Code:
                 SendClientMessage(playeridCOLOR_ORANGE"You Are Now Immune To Almost Everything in this world");
                 
SetPlayerHealth(playerid99999); 
Sorry son you're not immune to everything in the world, actually you're not immune to anything lol that's not how 'god mode' works at all.

And these arrays in the variables:
Code:
new perkcd[MAX_PLAYERS][10];
new perks[MAX_PLAYERS][10][5];
Don't make any sense either, you didn't even use them all and i'm not sure why it was needed in the first place.

This at OnDialogResponse:

Code:
       return 0;
    }
    return 1;
}
You're supposed to return 0 at the end of OnDialogResponse to pass it on to the next script and not limit it to this certain one.

Congrats on your spaghetti code keep bumping it more maybe it'll get better.
I didn't really want to get all pissy but I don't understand why bump a release if you're not announcing an update? Doesn't make any sense.

*Looks at Pottus* Not decent enough to be a release, 1-star from me. ^-^
__________________
Be creative.

[Github]:Link [Gists]:Link [Forum]:Link [Server]:Link [Discord]:Link


RogueDrifter is offline   Reply With Quote
Old 24/06/2018, 09:56 AM   #8
CaptainBoi
Huge Clucker
 
CaptainBoi's Avatar
 
Join Date: May 2018
Location: Inside Game
Posts: 265
Reputation: 25
Default Re: Perks System (v: [On Update]) [DINI, ZCMD]

i a also improved to mysql but this was my 1st release as dini and on that time i id not knew mysql much but now i m good at mysql so i dont need to bump over here becuz now my releases will be with Mysql or sqlite
__________________
Code:
Releases
[FilterScript] Dynamic MySQL GPS System
[Tutorial] How to make TDM Team Selection.
[Include] moneybar.inc || Coloured Moneybar || Released
[Tutorial] PAWN Compiler In Notepad++
[FilterScript] Perks System (v: [On Update]) [DINI, ZCMD]
[FilterScript] Realistic Transmission Speedometer
CaptainBoi is offline   Reply With Quote
Old 24/06/2018, 10:03 AM   #9
Calgon
Godfather
 
Calgon's Avatar
 
Join Date: Jan 2009
Posts: 6,466
Reputation: 1126
Default Re: Perks System (v: [On Update]) [DINI, ZCMD]

Quote:
Originally Posted by CaptainBoi View Post
i a also improved to mysql but this was my 1st release as dini and on that time i id not knew mysql much but now i m good at mysql so i dont need to bump over here becuz now my releases will be with Mysql or sqlite
w h a t
Calgon is offline   Reply With Quote
Old 24/06/2018, 10:28 AM   #10
CodeStyle175
Banned
 
Join Date: Apr 2014
Posts: 473
Reputation: 35
Default Re: Perks System (v: [On Update]) [DINI, ZCMD]

whats the point of releasing such scripts in 2018 are you trying to show that you learned to code something or what are you even trying?
* don't use dini.
* you create function for player name and then you dont even use it.
* string sizes are too big wasting resources.
* use more arrays.
CodeStyle175 is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
[FilterScript] Simple VIP system on months with (ZCMD + sscanf + Dini) IceBilizard Filterscripts 8 21/08/2018 03:01 PM
[Tutorial] Making a very simple VIP system with /setvip command using dini+sscanf+ZCMD electrux Tutorials 2 25/07/2012 10:00 AM
dini/zcmd /register and /login system? cod5devious Scripting Help 4 29/05/2012 09:56 PM
[HELP]About register/login system[zcmd+dini] ServerScripter Scripting Help 2 04/02/2012 05:59 PM
A Simple Registration System with zcmd+dini? ServerScripter Scripting Help 10 04/09/2011 11:28 PM


All times are GMT. The time now is 10:40 PM.


Powered by vBulletin® Version 3.8.6
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.